[SPARK-26978][SQL][FOLLOWUP] Initialize date-time constants by foldable expressions #25116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@srowen @hvanhovell Please, review the PR. |
hvanhovell
approved these changes
Jul 11, 2019
Contributor
hvanhovell
left a comment
hvanhovell
left a comment
There was a problem hiding this comment.
LGTM - pending jenkins
srowen
approved these changes
Jul 11, 2019
dongjoon-hyun
approved these changes
Jul 11, 2019
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM, too.
This is the same logic from delta/DateTimeUtils.scala.
|
Test build #107537 has finished for PR 25116 at commit
|
Contributor
|
Merging to master. |
vinodkc
pushed a commit
to vinodkc/spark
that referenced
this pull request
Jul 18, 2019
…le expressions ## What changes were proposed in this pull request? Reverted initialization of date-time constants in `DateTimeUtils` introduced by apache#23878. As a comment in [Delta repo](https://github.com/delta-io/delta) states, the compiler can do additional optimizations if values can be calculated at compile time: https://github.com/delta-io/delta/blob/master/src/main/scala/org/apache/spark/sql/delta/util/DateTimeUtils.scala#L63-L75 ## How was this patch tested? This was tested by existing test suites. Closes apache#25116 from MaxGekk/datetime-consts-init. Authored-by: Maxim Gekk <[email protected]> Signed-off-by: herman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Reverted initialization of date-time constants in
DateTimeUtilsintroduced by #23878. As a comment in Delta repo states, the compiler can do additional optimizations if values can be calculated at compile time: https://github.com/delta-io/delta/blob/master/src/main/scala/org/apache/spark/sql/delta/util/DateTimeUtils.scala#L63-L75How was this patch tested?
This was tested by existing test suites.