[SPARK-28343][SQL][TEST] Enabling cartesian product and ansi mode for PostgreSQL testing

[wangyum]

What changes were proposed in this pull request?

This pr enables spark.sql.crossJoin.enabled and spark.sql.parser.ansi.enabled for PostgreSQL test.

How was this patch tested?

manual tests:
Run test.sql in pgSQL directory and in inputs directory:

cat <<EOF > test.sql
create or replace temporary view t1 as
select * from (values(1), (2)) as v (val);

create or replace temporary view t2 as
select * from (values(2), (1)) as v (val);

select t1.*, t2.* from t1 join t2;
EOF

[wangyum]

@maropu I didn't enable spark.sql.parser.ansi.enabled because:

spark-sql> set spark.sql.parser.ansi.enabled=true;
spark.sql.parser.ansi.enabled	true
spark-sql> select 1 as false;
Error in query:
no viable alternative at input 'false'(line 1, pos 12)

== SQL ==
select 1 as false
------------^^^

spark-sql> select 1 as minus;
Error in query:
no viable alternative at input 'minus'(line 1, pos 12)

== SQL ==
select 1 as minus
------------^^^

Is this we expected?

[maropu]

ur, looks bad.... I checkd the reserved keywords in Postgresql again;
https://www.postgresql.org/docs/current/sql-keywords-appendix.html
FALSE is reserved, but the qyery works well in postgresql;

postgres=# select 1 as false;
 false 
-------
     1
(1 row)

How about Oracle and the other databases? Can they accept that query, too?

[SparkQA]

Test build #107509 has finished for PR 25109 at commit 86ca933.

• This patch fails due to an unknown error code, -9.
• This patch merges cleanly.
• This patch adds no public classes.

[wangyum]

Teradata, Vertica, Oracle, SQL Server and DB2 can accept these queries.

[wangyum]

retest this please

[maropu]

oh, I see.... If so, I think Spark might need to accept these queries with ansi=true...

[maropu]

IMO we need to make spark compatible with these DBMSs with ansi=true. So, how about setting ansi=true for the PostgreSQL tests by default and turning off the ansi mode for these queries like this?

set ansi=false;
select 1 as false;
set ansi=true;

Then, filing a jira for these unsupported behaviours?

[SparkQA]

Test build #107521 has finished for PR 25109 at commit 86ca933.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #107626 has finished for PR 25109 at commit 45af58f.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #107628 has finished for PR 25109 at commit 4a66a89.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[dongjoon-hyun]

Please add SPARK-28349 before this line.

[dongjoon-hyun]

Thank you for swift update according to the decision, @wangyum !
If we add SPARK-28349 comment explicitly, the others looks good.
(If we forgot to add that comment, the future developers will ask about that.)

cc @gatorsmile and @maropu .

[SparkQA]

Test build #107634 has finished for PR 25109 at commit 8ce7af4.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[dongjoon-hyun]

+1, LGTM. Merged to master.
Thank you, @wangyum and @maropu !