[SPARK-28334][SQL][TEST] Port select.sql #25096
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #107455 has finished for PR 25096 at commit
|
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
Outdated
Show resolved
Hide resolved
|
Test build #107466 has finished for PR 25096 at commit
|
Member
|
Hi, @maropu . |
|
Test build #107491 has finished for PR 25096 at commit
|
Member
|
I left one comment though, it looks ok to me. |
maropu
reviewed
Jul 11, 2019
|
Test build #107532 has finished for PR 25096 at commit
|
dongjoon-hyun
approved these changes
Jul 11, 2019
vinodkc
pushed a commit
to vinodkc/spark
that referenced
this pull request
Jul 18, 2019
## What changes were proposed in this pull request? This PR is to port select.sql from PostgreSQL regression tests. https://github.com/postgres/postgres/blob/REL_12_BETA2/src/test/regress/sql/select.sql The expected results can be found in the link: https://github.com/postgres/postgres/blob/REL_12_BETA2/src/test/regress/expected/select.out When porting the test cases, found four PostgreSQL specific features that do not exist in Spark SQL: [SPARK-28010](https://issues.apache.org/jira/browse/SPARK-28010): Support ORDER BY ... USING syntax [SPARK-28329](https://issues.apache.org/jira/browse/SPARK-28329): Support SELECT INTO syntax [SPARK-28330](https://issues.apache.org/jira/browse/SPARK-28330): Enhance query limit [SPARK-28296](https://issues.apache.org/jira/browse/SPARK-28296): Improved VALUES support Also, found one inconsistent behavior: [SPARK-28333](https://issues.apache.org/jira/browse/SPARK-28333): `NULLS FIRST` for `DESC` and `NULLS LAST` for `ASC` ## How was this patch tested? N/A Closes apache#25096 from wangyum/SPARK-28334. Authored-by: Yuming Wang <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is to port select.sql from PostgreSQL regression tests. https://github.com/postgres/postgres/blob/REL_12_BETA2/src/test/regress/sql/select.sql
The expected results can be found in the link: https://github.com/postgres/postgres/blob/REL_12_BETA2/src/test/regress/expected/select.out
When porting the test cases, found four PostgreSQL specific features that do not exist in Spark SQL:
SPARK-28010: Support ORDER BY ... USING syntax
SPARK-28329: Support SELECT INTO syntax
SPARK-28330: Enhance query limit
SPARK-28296: Improved VALUES support
Also, found one inconsistent behavior:
SPARK-28333:
NULLS FIRSTforDESCandNULLS LASTforASCHow was this patch tested?
N/A