-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-18299][SQL] Allow more aggregations on KeyValueGroupedDataset #24993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
jenkins this is ok to test |
|
Test build #107041 has finished for PR 24993 at commit
|
|
Test build #107068 has finished for PR 24993 at commit
|
sql/core/src/main/scala/org/apache/spark/sql/KeyValueGroupedDataset.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/KeyValueGroupedDataset.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/KeyValueGroupedDataset.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/KeyValueGroupedDataset.scala
Outdated
Show resolved
Hide resolved
|
Test build #107319 has finished for PR 24993 at commit
|
|
Test build #107320 has finished for PR 24993 at commit
|
|
Retest this please. |
|
Hi, @gatorsmile, @cloud-fan , @JoshRosen . |
|
Test build #107716 has finished for PR 24993 at commit
|
|
Retest this please. |
|
Test build #107744 has finished for PR 24993 at commit
|
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Merged to master.
|
Thank you, @nooberfsh and @JoshRosen . |
|
@nooberfsh . What is your Apache JIRA ID? I want to add you to the Apache Spark Contributor group and assign SPARK-18299 to you. |
## What changes were proposed in this pull request? Add 4 additional agg to KeyValueGroupedDataset ## How was this patch tested? New test in DatasetSuite for typed aggregation Closes apache#24993 from nooberfsh/sqlagg. Authored-by: nooberfsh <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
but it can not be used in 2.4.3, is it not be published? |
|
Correct, @zhouzach . SPARK-18299 is Apache Spark 3.0.0. FYI, we don't backport |
What changes were proposed in this pull request?
Add 4 additional agg to KeyValueGroupedDataset
How was this patch tested?
New test in DatasetSuite for typed aggregation