Skip to content

Conversation

@nooberfsh
Copy link
Contributor

What changes were proposed in this pull request?

Add 4 additional agg to KeyValueGroupedDataset

How was this patch tested?

New test in DatasetSuite for typed aggregation

@JoshRosen
Copy link
Contributor

jenkins this is ok to test

@SparkQA
Copy link

SparkQA commented Jun 29, 2019

Test build #107041 has finished for PR 24993 at commit 9e1aacb.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 1, 2019

Test build #107068 has finished for PR 24993 at commit e1a3442.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 8, 2019

Test build #107319 has finished for PR 24993 at commit 1fbe526.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 8, 2019

Test build #107320 has finished for PR 24993 at commit 3520138.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

Retest this please.

@dongjoon-hyun
Copy link
Member

Hi, @gatorsmile, @cloud-fan , @JoshRosen .
Since this is a very old issue, I'm wondering if this has not been considered in order to keep the API concise. Can we have this in Apache Spark 3.0.0?

@SparkQA
Copy link

SparkQA commented Jul 16, 2019

Test build #107716 has finished for PR 24993 at commit 3520138.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

Retest this please.

@SparkQA
Copy link

SparkQA commented Jul 16, 2019

Test build #107744 has finished for PR 24993 at commit 3520138.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Merged to master.

@dongjoon-hyun
Copy link
Member

Thank you, @nooberfsh and @JoshRosen .

@dongjoon-hyun
Copy link
Member

@nooberfsh . What is your Apache JIRA ID? I want to add you to the Apache Spark Contributor group and assign SPARK-18299 to you.

vinodkc pushed a commit to vinodkc/spark that referenced this pull request Jul 18, 2019
## What changes were proposed in this pull request?

Add 4 additional agg to KeyValueGroupedDataset

## How was this patch tested?

New test in DatasetSuite for typed aggregation

Closes apache#24993 from nooberfsh/sqlagg.

Authored-by: nooberfsh <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
@zhouzach
Copy link

zhouzach commented Aug 2, 2019

+1, LGTM. Merged to master.

but it can not be used in 2.4.3, is it not be published?

@dongjoon-hyun
Copy link
Member

Correct, @zhouzach . SPARK-18299 is Apache Spark 3.0.0.

FYI, we don't backport New features are Improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants