[SPARK-28129][SQL][TEST] Port float8.sql #24931
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #106761 has finished for PR 24931 at commit
|
|
Test build #107441 has finished for PR 24931 at commit
|
Member
Author
|
retest this please |
|
Test build #107444 has finished for PR 24931 at commit
|
Member
Member
Author
|
Thank you @dongjoon-hyun . I will update it later. |
wangyum
commented
Jul 15, 2019
|
Test build #107679 has finished for PR 24931 at commit
|
| SELECT double('Infinity') + 100.0; | ||
| -- [SPARK-27768] Infinity, -Infinity, NaN should be recognized in a case insensitive manner | ||
| SELECT double('Infinity') / double('Infinity'); | ||
| SELECT double('NaN') / double('NaN'); |
dongjoon-hyun
approved these changes
Jul 16, 2019
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM (except one minor comment request).
Most differences are filed correctly. Thank you so much, @wangyum .
|
Test build #107713 has finished for PR 24931 at commit
|
|
Test build #107721 has finished for PR 24931 at commit
|
Member
Author
|
retest this please |
|
Test build #107725 has finished for PR 24931 at commit
|
Member
|
Merged to master. |
vinodkc
pushed a commit
to vinodkc/spark
that referenced
this pull request
Jul 18, 2019
## What changes were proposed in this pull request? This PR is to port float8.sql from PostgreSQL regression tests. https://github.com/postgres/postgres/blob/REL_12_BETA2/src/test/regress/sql/float8.sql The expected results can be found in the link: https://github.com/postgres/postgres/blob/REL_12_BETA2/src/test/regress/expected/float8.out When porting the test cases, found six PostgreSQL specific features that do not exist in Spark SQL: [SPARK-28060](https://issues.apache.org/jira/browse/SPARK-28060): Double type can not accept some special inputs [SPARK-28027](https://issues.apache.org/jira/browse/SPARK-28027): Spark SQL does not support prefix operator `` and `|/` [SPARK-28061](https://issues.apache.org/jira/browse/SPARK-28061): Support for converting float to binary format [SPARK-23906](https://issues.apache.org/jira/browse/SPARK-23906): Support Truncate number [SPARK-28134](https://issues.apache.org/jira/browse/SPARK-28134): Missing Trigonometric Functions Also, found two bug: [SPARK-28024](https://issues.apache.org/jira/browse/SPARK-28024): Incorrect value when out of range [SPARK-28135](https://issues.apache.org/jira/browse/SPARK-28135): ceil/ceiling/floor/power returns incorrect values Also, found four inconsistent behavior: [SPARK-27923](https://issues.apache.org/jira/browse/SPARK-27923): Spark SQL insert bad inputs to NULL [SPARK-28028](https://issues.apache.org/jira/browse/SPARK-28028): Cast numeric to integral type need round [SPARK-27923](https://issues.apache.org/jira/browse/SPARK-27923): Spark SQL returns NULL when dividing by zero [SPARK-28007](https://issues.apache.org/jira/browse/SPARK-28007): Caret operator (^) means bitwise XOR in Spark/Hive and exponentiation in Postgres ## How was this patch tested? N/A Closes apache#24931 from wangyum/SPARK-28129. Authored-by: Yuming Wang <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is to port float8.sql from PostgreSQL regression tests. https://github.com/postgres/postgres/blob/REL_12_BETA2/src/test/regress/sql/float8.sql
The expected results can be found in the link: https://github.com/postgres/postgres/blob/REL_12_BETA2/src/test/regress/expected/float8.out
When porting the test cases, found six PostgreSQL specific features that do not exist in Spark SQL:
SPARK-28060: Double type can not accept some special inputs
SPARK-28027: Spark SQL does not support prefix operator
@and|/SPARK-28061: Support for converting float to binary format
SPARK-23906: Support Truncate number
SPARK-28134: Missing Trigonometric Functions
Also, found two bug:
SPARK-28024: Incorrect value when out of range
SPARK-28135: ceil/ceiling/floor/power returns incorrect values
Also, found four inconsistent behavior:
SPARK-27923: Spark SQL insert bad inputs to NULL
SPARK-28028: Cast numeric to integral type need round
SPARK-27923: Spark SQL returns NULL when dividing by zero
SPARK-28007: Caret operator (^) means bitwise XOR in Spark/Hive and exponentiation in Postgres
How was this patch tested?
N/A