[SPARK-28055][SS][DSTREAMS] Add delegation token custom AdminClient configurations. #24875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@koertkuipers the feature is on the way what we've spoken about. Ping me if you think this area lacks something. |
|
Test build #106513 has finished for PR 24875 at commit
|
Contributor
|
looks good to me |
Contributor
Author
|
cc @vanzin |
vanzin
reviewed
Jun 28, 2019
...kafka-0-10-token-provider/src/main/scala/org/apache/spark/kafka010/KafkaTokenSparkConf.scala
Outdated
Show resolved
Hide resolved
Contributor
|
this branch works for me to set |
Contributor
Author
|
@koertkuipers Thanks for testing it! |
|
Test build #107072 has finished for PR 24875 at commit
|
|
Test build #107077 has finished for PR 24875 at commit
|
|
Test build #107075 has finished for PR 24875 at commit
|
Contributor
|
retest this please |
|
Test build #107488 has finished for PR 24875 at commit
|
Contributor
|
Merging to master. |
vinodkc
pushed a commit
to vinodkc/spark
that referenced
this pull request
Jul 18, 2019
…onfigurations. ## What changes were proposed in this pull request? At the moment Kafka delegation tokens are fetched through `AdminClient` but there is no possibility to add custom configuration parameters. In [options](https://spark.apache.org/docs/2.4.3/structured-streaming-kafka-integration.html#kafka-specific-configurations) there is already a possibility to add custom configurations. In this PR I've added similar this possibility to `AdminClient`. ## How was this patch tested? Existing + added unit tests. ``` cd docs/ SKIP_API=1 jekyll build ``` Manual webpage check. Closes apache#24875 from gaborgsomogyi/SPARK-28055. Authored-by: Gabor Somogyi <[email protected]> Signed-off-by: Marcelo Vanzin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
At the moment Kafka delegation tokens are fetched through
AdminClientbut there is no possibility to add custom configuration parameters. In options there is already a possibility to add custom configurations.In this PR I've added similar this possibility to
AdminClient.How was this patch tested?
Existing + added unit tests.
Manual webpage check.