[SPARK-19799] Support WITH clause (CTE) in subqueries #22936
Conversation
…only grammar support.
gbloisi
changed the title
|
ok to test |
|
Test build #98453 has finished for PR 22936 at commit
|
FIX: Scalastyle checks failed at following occurrences: [error] /home/jenkins/workspace/SparkPullRequestBuilder/sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala:545: File line length exceeds 100 characters
|
Test build #98568 has finished for PR 22936 at commit
|
FIX: [error] /home/jenkins/workspace/SparkPullRequestBuilder/sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala:545:79: Whitespace at end of line
|
Test build #98569 has finished for PR 22936 at commit
|
| Row(5, "5") :: Row(4, "4") :: Nil) | ||
| } | ||
|
|
||
| test("SPARK-19799: Support WITH clause in subqueries") { |
There was a problem hiding this comment.
Could you add more test cases? For example, can a with clause in a subquery shadow a with clause in an enclosing query with the same name? Another example, use with clauses in a subquery expression?
There was a problem hiding this comment.
I need to find some spare time for that, but I'll surely do sooner or later. I assumed that most of the correctness comes from #15146 but surely there may be interactions that goes beyond that.
|
Can one of the admins verify this patch? |
|
@gbloisi Any update? |
|
@chrysanxia Could you take over this? |
|
@gatorsmile @gbloisi @chrysanxia may I take over this? |
|
@gatorsmile here is my PR: #24831 |
7 participants
Because of SPARK-17590 support of WITH clause (CTE) in subqueries requires only grammar support.
Test for augmented syntax is provided.