[SPARK-22473][TEST] Replace deprecated AsyncAssertions.Waiter and methods of java.sql.Date #19696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
approved these changes
Nov 8, 2017
|
Test build #83600 has finished for PR 19696 at commit
|
|
Merged to master |
asfgit
pushed a commit
that referenced
this pull request
Dec 4, 2017
## What changes were proposed in this pull request? #19696 replaced the deprecated usages for `Date` and `Waiter`, but a few methods were missed. The PR fixes the forgotten deprecated usages. ## How was this patch tested? existing UTs Author: Marco Gaido <[email protected]> Closes #19875 from mgaido91/SPARK-22473_FOLLOWUP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In
spark-sqlmodule tests there are deprecations warnings caused by the usage of deprecated methods ofjava.sql.Dateand the usage of the deprecatedAsyncAssertions.Waiterclass.This PR replace the deprecated methods of
java.sql.Datewith non-deprecated ones (usingCalendarwhere needed). It replaces also the deprecatedorg.scalatest.concurrent.AsyncAssertions.Waiterwithorg.scalatest.concurrent.Waiters._.How was this patch tested?
existing UTs