Skip to content

Conversation

yanboliang
Copy link
Contributor

What changes were proposed in this pull request?

Remove unnecessary default value setting for all evaluators, as we have set them in corresponding HasXXX base classes.

How was this patch tested?

Existing tests.

@SparkQA
Copy link

SparkQA commented Sep 17, 2017

Test build #81857 has finished for PR 19262 at commit 84c6c9e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

@WeichenXu123 WeichenXu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@yanboliang
Copy link
Contributor Author

Merged into master. Thanks for reviewing.

@asfgit asfgit closed this in 2f96242 Sep 19, 2017
@yanboliang yanboliang deleted the evaluation branch September 19, 2017 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants