[SPARK-20877][SPARKR] refactor tests to basic tests only for CRAN #18264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #77884 has finished for PR 18264 at commit
|
Member
Author
|
everything passed, verified all tests are run on Jenkins/AppVeyor |
Member
Author
|
separate issue: though I see that in the policy we could request to skip building vignettes |
Member
Author
|
merged to master/2.2 |
asfgit
pushed a commit
that referenced
this pull request
Jun 11, 2017
## What changes were proposed in this pull request? Move all existing tests to non-installed directory so that it will never run by installing SparkR package For a follow-up PR: - remove all skip_on_cran() calls in tests - clean up test timer - improve or change basic tests that do run on CRAN (if anyone has suggestion) It looks like `R CMD build pkg` will still put pkg\tests (ie. the full tests) into the source package but `R CMD INSTALL` on such source package does not install these tests (and so `R CMD check` does not run them) ## How was this patch tested? - [x] unit tests, Jenkins - [x] AppVeyor - [x] make a source package, install it, `R CMD check` it - verify the full tests are not installed or run Author: Felix Cheung <[email protected]> Closes #18264 from felixcheung/rtestset. (cherry picked from commit dc4c351) Signed-off-by: Felix Cheung <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Jun 13, 2017
## What changes were proposed in this pull request? Fix test file path. This is broken in #18264 and undetected since R-only changes don't build core and subsequent post-commit with the change built fine (again because it wasn't building core) actually appveyor builds everything but it's not running scala suites ... ## How was this patch tested? jenkins srowen gatorsmile Author: Felix Cheung <[email protected]> Closes #18283 from felixcheung/rsubmitsuite. (cherry picked from commit 278ba7a) Signed-off-by: Felix Cheung <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Jun 13, 2017
## What changes were proposed in this pull request? Fix test file path. This is broken in #18264 and undetected since R-only changes don't build core and subsequent post-commit with the change built fine (again because it wasn't building core) actually appveyor builds everything but it's not running scala suites ... ## How was this patch tested? jenkins srowen gatorsmile Author: Felix Cheung <[email protected]> Closes #18283 from felixcheung/rsubmitsuite.
dataknocker
pushed a commit
to dataknocker/spark
that referenced
this pull request
Jun 16, 2017
## What changes were proposed in this pull request? Move all existing tests to non-installed directory so that it will never run by installing SparkR package For a follow-up PR: - remove all skip_on_cran() calls in tests - clean up test timer - improve or change basic tests that do run on CRAN (if anyone has suggestion) It looks like `R CMD build pkg` will still put pkg\tests (ie. the full tests) into the source package but `R CMD INSTALL` on such source package does not install these tests (and so `R CMD check` does not run them) ## How was this patch tested? - [x] unit tests, Jenkins - [x] AppVeyor - [x] make a source package, install it, `R CMD check` it - verify the full tests are not installed or run Author: Felix Cheung <[email protected]> Closes apache#18264 from felixcheung/rtestset.
dataknocker
pushed a commit
to dataknocker/spark
that referenced
this pull request
Jun 16, 2017
## What changes were proposed in this pull request? Fix test file path. This is broken in apache#18264 and undetected since R-only changes don't build core and subsequent post-commit with the change built fine (again because it wasn't building core) actually appveyor builds everything but it's not running scala suites ... ## How was this patch tested? jenkins srowen gatorsmile Author: Felix Cheung <[email protected]> Closes apache#18283 from felixcheung/rsubmitsuite.
felixcheung
added a commit
to felixcheung/spark
that referenced
this pull request
Sep 9, 2017
## What changes were proposed in this pull request? Fix test file path. This is broken in apache#18264 and undetected since R-only changes don't build core and subsequent post-commit with the change built fine (again because it wasn't building core) actually appveyor builds everything but it's not running scala suites ... ## How was this patch tested? jenkins srowen gatorsmile Author: Felix Cheung <[email protected]> Closes apache#18283 from felixcheung/rsubmitsuite. (cherry picked from commit 278ba7a) Signed-off-by: Felix Cheung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Move all existing tests to non-installed directory so that it will never run by installing SparkR package
For a follow-up PR:
It looks like
R CMD build pkgwill still put pkg\tests (ie. the full tests) into the source package butR CMD INSTALLon such source package does not install these tests (and soR CMD checkdoes not run them)How was this patch tested?
R CMD checkit - verify the full tests are not installed or run