[SPARK-20630] [Web UI] Fixed column visibility in Executor Tab #17904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
approved these changes
May 8, 2017
|
Test build #76594 has finished for PR 17904 at commit
|
Member
Author
|
Jenkins, retest this please |
Member
|
Please rebase to pick up fix for R tests |
Member
|
This is kinda weird - I don't know why it's running R tests |
|
Test build #76607 has finished for PR 17904 at commit
|
Member
Author
|
Jenkins, retest this please |
Member
Author
|
I'm not sure why it's failing those tests, plus my branch is up to date with master (minus one unrelated commit) |
|
Test build #76620 has started for PR 17904 at commit |
Contributor
|
WFM. Thanks @ajbozarth! The following worked fine (http://localhost:4040/executors/): |
jaceklaskowski
approved these changes
May 9, 2017
Contributor
jaceklaskowski
left a comment
jaceklaskowski
left a comment
There was a problem hiding this comment.
Worked fine! Thanks.
Member
Author
|
Jenkins, retest this please |
Member
Author
|
weird test failure and thanks for the review @jaceklaskowski |
|
Test build #76692 has finished for PR 17904 at commit
|
Member
Author
|
@srowen passed test, this good to merge? |
Member
|
Merged to master/2.2 |
asfgit
pushed a commit
that referenced
this pull request
May 10, 2017
## What changes were proposed in this pull request? #14617 added new columns to the executor table causing the visibility checks for the logs and threadDump columns to toggle the wrong columns since they used hard-coded column numbers. I've updated the checks to use column names instead of numbers so future updates don't accidentally break this again. Note: This will also need to be back ported into 2.2 since #14617 was merged there ## How was this patch tested? Manually tested Author: Alex Bozarth <[email protected]> Closes #17904 from ajbozarth/spark20630. (cherry picked from commit ca4625e) Signed-off-by: Sean Owen <[email protected]>
lycplus
pushed a commit
to lycplus/spark
that referenced
this pull request
May 24, 2017
## What changes were proposed in this pull request? apache#14617 added new columns to the executor table causing the visibility checks for the logs and threadDump columns to toggle the wrong columns since they used hard-coded column numbers. I've updated the checks to use column names instead of numbers so future updates don't accidentally break this again. Note: This will also need to be back ported into 2.2 since apache#14617 was merged there ## How was this patch tested? Manually tested Author: Alex Bozarth <[email protected]> Closes apache#17904 from ajbozarth/spark20630.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#14617 added new columns to the executor table causing the visibility checks for the logs and threadDump columns to toggle the wrong columns since they used hard-coded column numbers.
I've updated the checks to use column names instead of numbers so future updates don't accidentally break this again.
Note: This will also need to be back ported into 2.2 since #14617 was merged there
How was this patch tested?
Manually tested