Skip to content

Conversation

@actuaryzhang
Copy link
Contributor

@actuaryzhang actuaryzhang commented Feb 4, 2017

What changes were proposed in this pull request?

Current version has error in vignettes:

model <- spark.bisectingKmeans(df, Sepal_Length ~ Sepal_Width, k = 4)
summary(kmeansModel)

kmeansModel does not exist...

@felixcheung @wangmiao1981

@actuaryzhang
Copy link
Contributor Author

Errors can be seen in #16794.

@actuaryzhang actuaryzhang changed the title [SparkR] fix error in vignettes [SPARK-19386][SparkR][Followup] fix error in vignettes Feb 4, 2017
@wangmiao1981
Copy link
Contributor

Good catch! Thanks for fixing it!

@felixcheung This is a hot-fix to build break. I don't know why Jenkins didn't catch it in the original PR.

@wangmiao1981
Copy link
Contributor

Jenkins, test this please.

@wangmiao1981
Copy link
Contributor

LGTM. Let us wait for Jenkins to build it.

@SparkQA
Copy link

SparkQA commented Feb 4, 2017

Test build #72338 has finished for PR 16799 at commit 9552f1f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member

Since this PR is a HOT fix, let me merge it now. Thanks!

@gatorsmile
Copy link
Member

Thanks! Merging to master.

@asfgit asfgit closed this in 050c20c Feb 4, 2017
@SparkQA
Copy link

SparkQA commented Feb 4, 2017

Test build #72342 has finished for PR 16799 at commit 9552f1f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@felixcheung
Copy link
Member

thanks @gatorsmile, @actuaryzhang @wangmiao1981
we did see it on the other PR but I didn't put the two together. And sorry for missing the fact that Jenkins was never run on the PR that broken the build - comment threads were too long and AppVeyor green checkmark was there (need to follow up) - will be more careful the next time.

@actuaryzhang actuaryzhang deleted the sparkRVignettes branch February 4, 2017 18:50
cmonkey pushed a commit to cmonkey/spark that referenced this pull request Feb 15, 2017
## What changes were proposed in this pull request?

Current version has error in vignettes:
```
model <- spark.bisectingKmeans(df, Sepal_Length ~ Sepal_Width, k = 4)
summary(kmeansModel)
```

`kmeansModel` does not exist...

felixcheung wangmiao1981

Author: actuaryzhang <[email protected]>

Closes apache#16799 from actuaryzhang/sparkRVignettes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants