[SPARK-19386][SPARKR][DOC] Bisecting k-means in SparkR documentation #16767
Conversation
krishnakalyan3
changed the title
|
Can one of the admins verify this patch? |
R/pkg/vignettes/sparkr-vignettes.Rmd
Outdated
|
|
||
| * Latent Dirichlet Allocation (LDA) | ||
|
|
||
| * Bisecting $k$-means |
There was a problem hiding this comment.
@felixcheung could you please let me know whats wrong here?
There was a problem hiding this comment.
these model names are in order
#### Clustering
* Gaussian Mixture Model (GMM)
* $k$-means Clustering
* Latent Dirichlet Allocation (LDA)
* Bisecting $k$-means
should be
#### Clustering
* Bisecting $k$-means
* Gaussian Mixture Model (GMM)
* $k$-means Clustering
* Latent Dirichlet Allocation (LDA)
R/pkg/vignettes/sparkr-vignettes.Rmd
Outdated
| perplexity | ||
| ``` | ||
|
|
||
| #### Bisecting k-means |
There was a problem hiding this comment.
same here. the model sections are in alphabetic order
docs/ml-clustering.md
Outdated
|
|
||
| <div data-lang="r" markdown="1"> | ||
|
|
||
| Refer to the [R API docs](api/R/spark.bisectingKmeans.html) for more details. {% include_example r/ml/bisectingKmeans.R %} |
There was a problem hiding this comment.
you will need to add this file r/ml/bisectingKmeans.R
There was a problem hiding this comment.
and this {% include_example r/ml/bisectingKmeans.R %} should be a separate line
docs/ml-clustering.md
Outdated
|
|
||
| Refer to the [R API docs](api/R/spark.bisectingKmeans.html) for more details. {% include_example r/ml/bisectingKmeans.R %} | ||
|
|
||
| {% include_example r/ml/lda.R %} |
R/pkg/vignettes/sparkr-vignettes.Rmd
Outdated
R/pkg/vignettes/sparkr-vignettes.Rmd
Outdated
There was a problem hiding this comment.
R function???s something wrong?
R/pkg/vignettes/sparkr-vignettes.Rmd
Outdated
There was a problem hiding this comment.
I don't see the change here either. Is there something wrong with your editor? node???s
krishnakalyan3
force-pushed
the
bisecting-kmeans
branch
from
5ba47b1 to
f907343
Compare
| sparkR.session(appName = "SparkR-ML-bisectingKmeans-example") | ||
|
|
||
| # $example on$ | ||
| irisDF <- suppressWarnings(createDataFrame(iris)) |
There was a problem hiding this comment.
suppressWarnings should not appear in example.
| fitted.model <- fitted(model, "centers") | ||
|
|
||
| # Model summary | ||
| showDF(fitted.model) |
There was a problem hiding this comment.
Model Summary should use summary method. Otherwise, change the comment.
|
@wangmiao1981 sorry, had made a erroneous commit. Could you please review the PR?. |
|
looking good to me. I'll wait for @wangmiao1981 to review. |
|
LGTM |
|
merged to master |
|
Jenkins build was not triggered for the last revision. It breaks the build. |
|
ouch, Jenkins was never run the entire time. I need to go double check why AppVeyor is passing. |
## What changes were proposed in this pull request? Update programming guide, example and vignette with Bisecting k-means. Author: krishnakalyan3 <[email protected]> Closes apache#16767 from krishnakalyan3/bisecting-kmeans.
4 participants
What changes were proposed in this pull request?
Update programming guide, example and vignette with Bisecting k-means.