Skip to content

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Oct 5, 2016

What changes were proposed in this pull request?

This PR proposes to close some stale PRs and ones suggested to be closed by committer(s) or obviously inappropriate PRs (e.g. branch to branch).

Closes #13458
Closes #15278
Closes #15294
Closes #15339
Closes #15283

How was this patch tested?

N/A

@HyukjinKwon
Copy link
Member Author

Just to defense myself, it seems the PR such 15339 against a branch to a branch leaving a failure mark for each commit in the branches (branch-2.0). Could you please take a look please @srowen ?

@HyukjinKwon
Copy link
Member Author

FYI, for 15294, the JIRA is set as Won't fix.

@SparkQA
Copy link

SparkQA commented Oct 5, 2016

Test build #66366 has finished for PR 15356 at commit a307b5e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I think 14565 and 15078 should be closed, I usually don't force close them unless it's been like a week and it hasn't been closed by the author.

You can add #15283 and it LGTM.

@HyukjinKwon
Copy link
Member Author

Do you mind if I ask to confirm #12355 too? if you are uncertain, I'd like to not add it here.

@srowen
Copy link
Member

srowen commented Oct 5, 2016

Same thing, I think. I agree it should probably be closed but given that there's not a big hurry, I like to do the courtesy of giving at least days if not a week for someone to reply. I just put it on my big to-do list for later (FWIW I manage all this stuff with Gmail Inbox snooze / reminders and it works quite well for me, to easily "check on X and act in Y days")

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Oct 5, 2016

Ah, sure. I just wanted to include as many as I could as I already opened this but yes maybe I was in a hurry. I will keep it in mind. Thank you for your tip.

@asfgit asfgit closed this in 5e9f32d Oct 6, 2016
@HyukjinKwon HyukjinKwon deleted the closing-prs branch October 16, 2016 08:30
zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 22, 2025
## What changes were proposed in this pull request?

This PR proposes to close some stale PRs and ones suggested to be closed by committer(s) or obviously inappropriate PRs (e.g. branch to branch).

Closes apache#13458
Closes apache#15278
Closes apache#15294
Closes apache#15339
Closes apache#15283

## How was this patch tested?

N/A

Author: hyukjinkwon <[email protected]>

Closes apache#15356 from HyukjinKwon/closing-prs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants