-
Notifications
You must be signed in to change notification settings - Fork 29k
[BUILD] Closing some stale PRs #15356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Just to defense myself, it seems the PR such 15339 against a branch to a branch leaving a failure mark for each commit in the branches (branch-2.0). Could you please take a look please @srowen ? |
|
FYI, for 15294, the JIRA is set as |
|
Test build #66366 has finished for PR 15356 at commit
|
srowen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I think 14565 and 15078 should be closed, I usually don't force close them unless it's been like a week and it hasn't been closed by the author.
You can add #15283 and it LGTM.
|
Do you mind if I ask to confirm #12355 too? if you are uncertain, I'd like to not add it here. |
|
Same thing, I think. I agree it should probably be closed but given that there's not a big hurry, I like to do the courtesy of giving at least days if not a week for someone to reply. I just put it on my big to-do list for later (FWIW I manage all this stuff with Gmail Inbox snooze / reminders and it works quite well for me, to easily "check on X and act in Y days") |
|
Ah, sure. I just wanted to include as many as I could as I already opened this but yes maybe I was in a hurry. I will keep it in mind. Thank you for your tip. |
## What changes were proposed in this pull request? This PR proposes to close some stale PRs and ones suggested to be closed by committer(s) or obviously inappropriate PRs (e.g. branch to branch). Closes apache#13458 Closes apache#15278 Closes apache#15294 Closes apache#15339 Closes apache#15283 ## How was this patch tested? N/A Author: hyukjinkwon <[email protected]> Closes apache#15356 from HyukjinKwon/closing-prs.
What changes were proposed in this pull request?
This PR proposes to close some stale PRs and ones suggested to be closed by committer(s) or obviously inappropriate PRs (e.g. branch to branch).
Closes #13458
Closes #15278
Closes #15294
Closes #15339
Closes #15283
How was this patch tested?
N/A