Skip to content

Conversation

@clockfly
Copy link
Contributor

@clockfly clockfly commented Aug 22, 2016

What changes were proposed in this pull request?

This is a sub-task of SPARK-16283 (Implement percentile_approx SQL function), which moves class QuantileSummaries to project catalyst so that it can be reused when implementing aggregation function percentile_approx.

How was this patch tested?

This PR only does class relocation, class implementation is not changed.

@SparkQA
Copy link

SparkQA commented Aug 22, 2016

Test build #64217 has finished for PR 14754 at commit 8ae3789.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class QuantileSummaries(
    • case class Stats(value: Double, g: Int, delta: Int)

@rxin
Copy link
Contributor

rxin commented Aug 22, 2016

Are there tests that we'd need to move?

@clockfly
Copy link
Contributor Author

@rxin updated.

@SparkQA
Copy link

SparkQA commented Aug 23, 2016

Test build #64268 has finished for PR 14754 at commit e8745e7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

thanks, merging to master!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants