[SPARK-6339][SQL] Supports CREATE TEMPORARY VIEW tableIdentifier AS query #12872
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,11 +37,21 @@ class SQLViewSuite extends QueryTest with SQLTestUtils with TestHiveSingleton { | |
| sqlContext.sql(s"DROP TABLE IF EXISTS jt") | ||
| } | ||
|
|
||
| test("nested views (interleaved with temporary views)") { | ||
| withView("jtv1", "jtv2", "jtv3", "temp_jtv1", "temp_jtv2", "temp_jtv3") { | ||
|
Contributor
There was a problem hiding this comment. Does withView("jtv1", "jtv2", "jtv3") {
withTempTable("temp_jtv1", "temp_jtv2", "temp_jtv3") {
// ...
}
}I'd suggest to make sure that
Contributor
There was a problem hiding this comment. (This applies to all test cases modified/introduced in this PR.)
Contributor
There was a problem hiding this comment. @clockfly had helped verify that |
||
| sql("CREATE VIEW jtv1 AS SELECT * FROM jt WHERE id > 3") | ||
| sql("CREATE VIEW jtv2 AS SELECT * FROM jtv1 WHERE id < 6") | ||
| checkAnswer(sql("select count(*) FROM jtv2"), Row(2)) | ||
|
|
||
| // Checks temporary views | ||
| sql("CREATE TEMPORARY VIEW temp_jtv1 AS SELECT * FROM jt WHERE id > 3") | ||
| sql("CREATE TEMPORARY VIEW temp_jtv2 AS SELECT * FROM temp_jtv1 WHERE id < 6") | ||
| checkAnswer(sql("select count(*) FROM temp_jtv2"), Row(2)) | ||
|
|
||
| // Checks interleaved temporary view and normal view | ||
| sql("CREATE TEMPORARY VIEW temp_jtv3 AS SELECT * FROM jt WHERE id > 3") | ||
| sql("CREATE VIEW jtv3 AS SELECT * FROM temp_jtv3 WHERE id < 6") | ||
| checkAnswer(sql("select count(*) FROM jtv3"), Row(2)) | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -57,6 +67,33 @@ class SQLViewSuite extends QueryTest with SQLTestUtils with TestHiveSingleton { | |
| } | ||
| } | ||
|
|
||
| test("error handling: fail if the temp view name contains the database prefix") { | ||
| // Fully qualified table name like "database.table" is not allowed for temporary view | ||
| val e = intercept[AnalysisException] { | ||
| sql("CREATE OR REPLACE TEMPORARY VIEW default.myabcdview AS SELECT * FROM jt") | ||
| } | ||
| assert(e.message.contains("It is not allowed to add database prefix")) | ||
| } | ||
|
|
||
| test("error handling: disallow IF NOT EXISTS for CREATE TEMPORARY VIEW") { | ||
| val e = intercept[AnalysisException] { | ||
| sql("CREATE TEMPORARY VIEW IF NOT EXISTS myabcdview AS SELECT * FROM jt") | ||
| } | ||
| assert(e.message.contains("It is not allowed to define a TEMPORARY view with IF NOT EXISTS")) | ||
| } | ||
|
|
||
| test("error handling: fail if the temp view sql itself is invalid") { | ||
| // A table that does not exist for temporary view | ||
| intercept[AnalysisException] { | ||
| sql("CREATE OR REPLACE TEMPORARY VIEW myabcdview AS SELECT * FROM table_not_exist1345") | ||
| } | ||
|
|
||
| // A column that does not exist, for temporary view | ||
| intercept[AnalysisException] { | ||
| sql("CREATE OR REPLACE TEMPORARY VIEW myabcdview AS SELECT random1234 FROM jt") | ||
| } | ||
| } | ||
|
|
||
| test("correctly parse CREATE VIEW statement") { | ||
| withSQLConf(SQLConf.NATIVE_VIEW.key -> "true") { | ||
| sql( | ||
|
|
@@ -69,18 +106,70 @@ class SQLViewSuite extends QueryTest with SQLTestUtils with TestHiveSingleton { | |
| } | ||
| } | ||
|
|
||
| test("correctly parse CREATE TEMPORARY VIEW statement") { | ||
| withView("testView") { | ||
| sql( | ||
| """CREATE TEMPORARY VIEW | ||
| |testView (c1 COMMENT 'blabla', c2 COMMENT 'blabla') | ||
| |TBLPROPERTIES ('a' = 'b') | ||
| |AS SELECT * FROM jt | ||
| |""".stripMargin) | ||
| checkAnswer(sql("SELECT c1, c2 FROM testView ORDER BY c1"), (1 to 9).map(i => Row(i, i))) | ||
| } | ||
| } | ||
|
|
||
| test("should NOT allow CREATE TEMPORARY VIEW when TEMPORARY VIEW with same name exists") { | ||
| withView("testView") { | ||
| sql("CREATE TEMPORARY VIEW testView AS SELECT id FROM jt") | ||
|
|
||
| val e = intercept[AnalysisException] { | ||
| sql("CREATE TEMPORARY VIEW testView AS SELECT id FROM jt") | ||
| } | ||
|
|
||
| assert(e.message.contains("Temporary table") && e.message.contains("already exists")) | ||
| } | ||
| } | ||
|
|
||
| test("should allow CREATE TEMPORARY VIEW when a permanent VIEW with same name exists") { | ||
| withView("testView", "default.testView") { | ||
| sql("CREATE VIEW testView AS SELECT id FROM jt") | ||
| sql("CREATE TEMPORARY VIEW testView AS SELECT id FROM jt") | ||
| } | ||
| } | ||
|
|
||
| test("should allow CREATE permanent VIEW when a TEMPORARY VIEW with same name exists") { | ||
| withView("testView", "default.testView") { | ||
| sql("CREATE TEMPORARY VIEW testView AS SELECT id FROM jt") | ||
| sql("CREATE VIEW testView AS SELECT id FROM jt") | ||
| } | ||
| } | ||
|
|
||
| test("correctly handle CREATE VIEW IF NOT EXISTS") { | ||
| withSQLConf(SQLConf.NATIVE_VIEW.key -> "true") { | ||
| withTable("jt2") { | ||
| withView("testView") { | ||
| sql("CREATE VIEW testView AS SELECT id FROM jt") | ||
|
|
||
| val df = (1 until 10).map(i => i -> i).toDF("i", "j") | ||
| df.write.format("json").saveAsTable("jt2") | ||
| sql("CREATE VIEW IF NOT EXISTS testView AS SELECT * FROM jt2") | ||
|
Contributor
There was a problem hiding this comment. Not related to this PR, but it's a waste to write a new persisted table here to do the test. We can simply create a view with different column number here: sql("CREATE VIEW IF NOT EXISTS testView AS SELECT id AS a, id AS b FROM jt") |
||
|
|
||
| // make sure our view doesn't change. | ||
| checkAnswer(sql("SELECT * FROM testView ORDER BY id"), (1 to 9).map(i => Row(i))) | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| test(s"correctly handle CREATE OR REPLACE TEMPORARY VIEW") { | ||
| withTable("jt2") { | ||
| withView("testView") { | ||
| sql("CREATE OR REPLACE TEMPORARY VIEW testView AS SELECT id FROM jt") | ||
| checkAnswer(sql("SELECT * FROM testView ORDER BY id"), (1 to 9).map(i => Row(i))) | ||
|
|
||
| sql("CREATE OR REPLACE TEMPORARY VIEW testView AS SELECT id AS i, id AS j FROM jt") | ||
| // make sure the view has been changed. | ||
| checkAnswer(sql("SELECT * FROM testView ORDER BY i"), (1 to 9).map(i => Row(i, i))) | ||
| } | ||
| } | ||
| } | ||
|
|
@@ -214,5 +303,4 @@ class SQLViewSuite extends QueryTest with SQLTestUtils with TestHiveSingleton { | |
| } | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does this semantic rule come from? Hive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to be consistent with DataSet API. When registering a temp table, it will remove the database prefix, here is the code:
spark/sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
Line 533 in 6ba17cd