SLING-12739 - selectively hide scripts and servlets from the Sling resolver #58
Conversation
|
Added integration tests, in branches for now, at: |
| @@ -460,6 +469,16 @@ private Resource getErrorResource(final SlingHttpServletRequest request) { | |||
| return res; | |||
| } | |||
|
|
|||
| /** @return true if the given Resource is hidden by our resourceHidingPredicate */ | |||
| private boolean isHidden(Resource r) { | |||
There was a problem hiding this comment.
I would explicitly mention that this method requires a non-null parameter (and that for this reason null-checks are missing).
| private boolean isHidden(Resource r) { | |
| private boolean isHidden(@NotNull Resource r) { |
There was a problem hiding this comment.
Good catch, thank you! Changed as suggested.
|
|
|
Closing this as I have applied the changes to the resolver-2.x branch in this commit: |
Work in progress, initial implementation with incomplete tests