Skip to content

workaround RB issue from depends-maven-plugin #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hboutemy
Copy link
Member

@hboutemy hboutemy commented Jun 8, 2023

@joerghoh
Copy link
Contributor

@hboutemy thanks for this PR.

I would rather want to update the version the depends-maven-plugin in our poms (https://issues.apache.org/jira/browse/SLING-11907) and not try to workaround it on a per-bundle level.

@hboutemy
Copy link
Member Author

hboutemy commented Jun 17, 2023

for sure, getting the initial plugin fixed is better, but 1.5.0 does not seem to be published yet, isn't it? https://repo1.maven.org/maven2/org/apache/servicemix/tooling/depends-maven-plugin/
https://issues.apache.org/jira/projects/SM/versions/12339645

kwin referenced this pull request in apache/sling-parent Jun 21, 2023
@joerghoh
Copy link
Contributor

@kwin yes, I assumed that the same process we use in Sling (closed ticket = part of a release) is also used in servicemix. Obviously it is not.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hboutemy
Copy link
Member Author

@joerghoh 1.5.0 release available https://repo1.maven.org/maven2/org/apache/servicemix/tooling/depends-maven-plugin/ :)

@joerghoh
Copy link
Contributor

thanks @hboutemy , we included it into SLING parent 52 (SLING-11907). I will update this bundle as soon as this version is released.

@hboutemy
Copy link
Member Author

hboutemy commented Jul 22, 2023

closing this PR as better replacement is apache/sling-parent#35 / https://issues.apache.org/jira/browse/SLING-11907
=> #39

@hboutemy hboutemy closed this Jul 22, 2023
@hboutemy hboutemy deleted the patch-1 branch July 22, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants