[#5017] Fix swagger/swagger-generator/generator-core OD tests
#5018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pem70
changed the title
swagger/swagger-generator/generator-core OD testsswagger/swagger-generator/generator-core OD tests
pem70
changed the title
swagger/swagger-generator/generator-core OD testsswagger/swagger-generator/generator-core OD tests
Contributor
|
rebase to update jdk17 image name |
pem70
force-pushed
the
fix-swagger-generator-core-OD-tests
branch
from
6e4cb30 to
b9aa02b
Compare
Contributor
Author
Rebased. Please review |
Contributor
Author
|
I verified the CI failure and confirmed it comes from the Consul demo test ( |
pem70
force-pushed
the
fix-swagger-generator-core-OD-tests
branch
2 times, most recently
from
bb210ea to
ac5e256
Compare
pem70
force-pushed
the
fix-swagger-generator-core-OD-tests
branch
3 times, most recently
from
ad7ba6e to
bb210ea
Compare
pem70
force-pushed
the
fix-swagger-generator-core-OD-tests
branch
from
bb210ea to
40356d3
Compare
Contributor
Author
|
Merged newer main branch |
Contributor
Author
|
Update to generate Swagger operations once per class instead of per method. This will improve performance and hopefully fix the CI error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Several tests (
TestApiResponse,TestOperationGenerator, andOperationMethodAnnotationProcessorTest) were identified as order-dependent (OD) flaky tests. See #5017Fix
This PR transitions the test class to the JUnit 5
@TestInstance(Lifecycle.PER_CLASS)lifecycle, replacing the shared static field with an instance-scoped variable initialized in@BeforeAll. This resolves order-dependent flakiness by eliminating global state pollution, while ensuring that the resource-intensive Swagger generation runs only once per class. This approach balances test isolation with the performance efficiency required to hopefully prevent resource exhaustion and timeouts in the CI environment.Checklist
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean install -Pitto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.