Skip to content

Conversation

@bunnysocks
Copy link
Contributor

Did you read the Contributor Guide?


Is this PR related to a ticket?


What changes were proposed in this PR?

This PR removes the unused global variable IMPLEMENTATION_STATUS from both
geoseries.py and geodataframe.py under sedona/spark/geopandas.

  • The variable was outdated and no longer referenced in the code.
  • Updated docstrings that previously mentioned IMPLEMENTATION_STATUS to refer instead to the Sedona GeoPandas documentation.

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API, so no documentation changes are needed.
  • Yes, documentation was updated.

Copy link
Collaborator

@petern48 petern48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @zhangfengcdt I wanted to check if you're okay with removing this, since I recall you introducing it originally. I didn't see much use for it, and I'm sure it's very out-of-date.

@jiayuasu jiayuasu requested a review from zhangfengcdt October 30, 2025 15:57
Copy link
Member

@zhangfengcdt zhangfengcdt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

The initial thought is to use this to help document the progress of the geopandas API in the documents. Since we now have all Python documents automatically generated, this can be deprecated.

@jiayuasu jiayuasu merged commit 293faff into apache:master Oct 30, 2025
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(geopandsa): Remove 'IMPLEMENTATION_STATUS' global variables

4 participants