Skip to content

PARQUET-1489: Insufficient documentation for UserDefinedPredicate.keep(T) #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zivanfi merged 1 commit into from
Jan 9, 2019
Merged

PARQUET-1489: Insufficient documentation for UserDefinedPredicate.keep(T) #588

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion parquet-column/src/main/java/org/apache/parquet/filter2/predicate/UserDefinedPredicate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,11 @@ public UserDefinedPredicate() { }

/**
* Return true to keep the record with this value, false to drop it.
* <p>
* This method shall handle {@code null} values returning whether this user defined predicate accepts {@code null}
* values or not.
*
* @param value a value
* @param value a value (might be {@code null})
* @return true to keep the record with the value, false to drop it
*/
public abstract boolean keep(T value);
Expand Down