Skip to content

PARQUET-1407: Fix binary values from dictionary encoding. #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rdblue wants to merge 1 commit into from
Closed

PARQUET-1407: Fix binary values from dictionary encoding. #551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion parquet-avro/src/main/java/org/apache/parquet/avro/AvroConverters.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,13 @@ public void setDictionary(Dictionary dictionary) {
}
}

public T prepareDictionaryValue(T value) {
return value;
}

@Override
public void addValueFromDictionary(int dictionaryId) {
parent.add(dict[dictionaryId]);
parent.add(prepareDictionaryValue(dict[dictionaryId]));
}
}

Expand Down Expand Up @@ -220,6 +224,11 @@ public FieldByteBufferConverter(ParentValueContainer parent) {
public ByteBuffer convert(Binary binary) {
return ByteBuffer.wrap(binary.getBytes());
}

@Override
public ByteBuffer prepareDictionaryValue(ByteBuffer value) {
return value.duplicate();
}
}

static final class FieldStringConverter extends BinaryConverter<String> {
Expand Down