Limit page size based on maximum row count

[asfimport]

For column index based filtering it is important to have enough pages for a column. In case of a perfectly matching encoding for the suitable data it can happen that all of the values can be encoded in one page (e.g. a column of an ascending counter).

With this improvement we would be able to limit the pages by the maximum number of rows to be written in it so we would have enough pages for every column.

Based on the benchmarks listed here 20k seems to be a good choice for the default value.

Reporter: Gabor Szadovszky / @gszadovszky
Assignee: Gabor Szadovszky / @gszadovszky

Related issues:

• Column indexes (is related to)
• Avoid Parquet pages with too many rows + try to make them aligned (is related to)
• Consider setting parquet_page_row_count_limit to 20000 by default (is related to)

PRs and other links:

• GitHub Pull Request #531
• GitHub Pull Request #537
• Page size limit to file size test results

_{Note: This issue was originally created as PARQUET-1414. Please see the migration documentation for further details.}

[asfimport]

Ryan Blue / @rdblue:
@gszadovszky, can you add a link to your benchmarks to this issue?

I think the conclusion we came to while discussing was between 10k and 20k, with 20k being the better choice for overall file size. Is 20k the planned default now?