[core] Support timestamp type in Iceberg compatibility #4318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwj6591812
reviewed
Oct 14, 2024
| | `TIMESTAMP`* | `timestamp` | | ||
| | `TIMESTAMP_LTZ`* | `timestamptz` | | ||
|
|
||
| *: `TIMESTAMP` and `TIMESTAMP_LTZ` type only support precision from 4 to 6 |
| + " v_varbinary VARBINARY(20),\n" | ||
| + " v_date DATE\n" | ||
| + " v_date DATE,\n" | ||
| // it seems that Iceberg Flink connector has some bug when filtering a |
| case TIMESTAMP_WITHOUT_TIME_ZONE: | ||
| case TIMESTAMP_WITH_LOCAL_TIME_ZONE: | ||
| int timestampPrecision = ((TimestampType) type).getPrecision(); | ||
| long timestampLong = |
Contributor
There was a problem hiding this comment.
Change the order of these two statements, for example:
Preconditions.checkArgument(
timestampPrecision > 3 && timestampPrecision <= 6,
"Paimon Iceberg compatibility only support timestamp type with precision from 4 to 6.");
long timestampLong =
ByteBuffer.wrap(bytes).order(ByteOrder.LITTLE_ENDIAN).getLong();
| "decimal(%d, %d)", decimalType.getPrecision(), decimalType.getScale()); | ||
| case TIMESTAMP_WITHOUT_TIME_ZONE: | ||
| int timestampPrecision = ((TimestampType) dataType).getPrecision(); | ||
| Preconditions.checkArgument( |
Contributor
There was a problem hiding this comment.
There are four place check this precision.
Should we extract this to reduce common code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
TIMESTAMPis a widely used data type. This PR supportsTIMESTAMPandTIMESTAMP_LTZtype in Iceberg compatibility.Tests
Unit tests and IT cases.
API and Format
No format changes.
Documentation
Document is also added.