ORC-1961: Support orc.compression.zstd.strategy
#2338
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Could you review this PR, @williamhyun ? |
cxzl25
approved these changes
Jul 24, 2025
Member
Author
|
Thank you, @cxzl25 . |
williamhyun
approved these changes
Jul 24, 2025
Member
williamhyun
left a comment
williamhyun
left a comment
There was a problem hiding this comment.
+1 LGTM, will be merging this now!
williamhyun
pushed a commit
that referenced
this pull request
Jul 24, 2025
### What changes were proposed in this pull request? This PR aims to support `orc.compression.zstd.strategy`. ### Why are the changes needed? To allow a user to choose a proper strategy based on their data. https://facebook.github.io/zstd/zstd_manual.html#Chapter5 ``` typedef enum { ZSTD_fast=1, ZSTD_dfast=2, ZSTD_greedy=3, ZSTD_lazy=4, ZSTD_lazy2=5, ZSTD_btlazy2=6, ZSTD_btopt=7, ZSTD_btultra=8, ZSTD_btultra2=9 /* note : new strategies _might_ be added in the future. Only the order (from fast to strong) is guaranteed */ } ZSTD_strategy; ``` ### How was this patch tested? Pass the CIs. ``` $ cd java $ mvn package -DskipTests -Pbenchmark $ cd bench $ time java -Dorc.compression.zstd.strategy=1 -jar core/target/orc-benchmarks-core-*-uber.jar generate data -d sales -c zstd -f orc ... 54.51s user 1.28s system 103% cpu 53.984 total $ time java -Dorc.compression.zstd.strategy=9 -jar core/target/orc-benchmarks-core-*-uber.jar generate data -d sales -c zstd -f orc ... 148.21s user 1.75s system 101% cpu 2:28.13 total ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2338 from dongjoon-hyun/ORC-1961. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: William Hyun <[email protected]> (cherry picked from commit 725fbc5) Signed-off-by: William Hyun <[email protected]>
Member
Author
|
Thank you, @williamhyun ! |
dongjoon-hyun
pushed a commit
to apache/spark
that referenced
this pull request
Jul 30, 2025
### What changes were proposed in this pull request? This PR aims to upgrade ORC to 2.2.0. 2.2.0 RC1 is currently under voting. ### Why are the changes needed? Apache ORC 2.2.0 is a new feature release. - https://github.com/apache/orc/releases/tag/v2.2.0 - apache/orc#2032 - apache/orc#2338 - apache/orc#2269 - apache/orc#2249 - apache/orc#2144 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #51676 from williamhyun/ORC-2.2.0. Authored-by: William Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to support
orc.compression.zstd.strategy.Why are the changes needed?
To allow a user to choose a proper strategy based on their data.
https://facebook.github.io/zstd/zstd_manual.html#Chapter5
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.