Skip to content

Conversation

@WillAyd
Copy link
Contributor

@WillAyd WillAyd commented Jun 19, 2025

What changes were proposed in this pull request?

Rather than pulling the build and example directory from gtest arguments, this pulls it from the build system.

Why are the changes needed?

When orc is used as a subproject, the current method of grabbing the arguments from the build system fails

How was this patch tested?

Tests were run locally

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the CPP label Jun 19, 2025
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make CIs happy, @WillAyd ?

@WillAyd WillAyd force-pushed the improve-gtest-cli branch 4 times, most recently from 0a650cd to 3955b59 Compare June 20, 2025 17:22
@WillAyd WillAyd force-pushed the improve-gtest-cli branch from 3955b59 to adf38ad Compare June 23, 2025 14:27
@WillAyd
Copy link
Contributor Author

WillAyd commented Jun 23, 2025

Sorry about the delay - all green!

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @WillAyd .
Merged to main for Apache ORC 2.2.0.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Jun 23, 2025

Oh my. ORC-2238 doesn't exist, @WillAyd . I'll reset this commit first.

Please don't do like this again. As you know, Apache repository uses ORC-XXX as a hyperlink pattern for the JIRA system.

Screenshot 2025-06-23 at 09 41 57

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is removed from master branch due to the invalid ORC JIRA ID.

@WillAyd
Copy link
Contributor Author

WillAyd commented Jun 23, 2025

Ah sorry - I used the issue number which is 2238. Where can I find the Jira number?

@dongjoon-hyun
Copy link
Member

Here is the Apache ORC developer guideline.

https://orc.apache.org/develop/

Each code change requires a jira to track the discussion of the change.

In addition, it seems that you missed my previous comment here.

@WillAyd
Copy link
Contributor Author

WillAyd commented Jun 23, 2025

OK great. I'll open a Jira ticket to track the github issue then. Should we reopen and update the title of this PR after that or should I create a new PR entirely?

Thanks for the patience - every project is a little different so its a challenge to keep track of all of their requirements :-)

@WillAyd
Copy link
Contributor Author

WillAyd commented Jun 23, 2025

https://issues.apache.org/jira/browse/ORC-1936 has been opened

@dongjoon-hyun dongjoon-hyun reopened this Jun 23, 2025
@dongjoon-hyun dongjoon-hyun changed the title ORC-2238: Get build and example dir from build system rather than gtest ORC-1936: Get build and example dir from build system rather than gtest Jun 23, 2025
@dongjoon-hyun dongjoon-hyun added this to the 2.2.0 milestone Jun 23, 2025
@dongjoon-hyun
Copy link
Member

Thank you. I reopened this PR with your new JIRA ID, ORC-1936 .

@dongjoon-hyun
Copy link
Member

After passing CI agains, I will put it back to main branch again.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Jun 23, 2025

Merged to the main branch again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants