-
Notifications
You must be signed in to change notification settings - Fork 505
ORC-1936: Get build and example dir from build system rather than gtest #2291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make CIs happy, @WillAyd ?
0a650cd to
3955b59
Compare
3955b59 to
adf38ad
Compare
|
Sorry about the delay - all green! |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Thank you, @WillAyd .
Merged to main for Apache ORC 2.2.0.
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is removed from master branch due to the invalid ORC JIRA ID.
|
Ah sorry - I used the issue number which is 2238. Where can I find the Jira number? |
|
Here is the Apache ORC developer guideline. https://orc.apache.org/develop/
In addition, it seems that you missed my previous comment here. |
|
OK great. I'll open a Jira ticket to track the github issue then. Should we reopen and update the title of this PR after that or should I create a new PR entirely? Thanks for the patience - every project is a little different so its a challenge to keep track of all of their requirements :-) |
|
https://issues.apache.org/jira/browse/ORC-1936 has been opened |
|
Thank you. I reopened this PR with your new JIRA ID, ORC-1936 . |
|
After passing CI agains, I will put it back to |
|
Merged to the |

What changes were proposed in this pull request?
Rather than pulling the build and example directory from gtest arguments, this pulls it from the build system.
Why are the changes needed?
When orc is used as a subproject, the current method of grabbing the arguments from the build system fails
How was this patch tested?
Tests were run locally
Was this patch authored or co-authored using generative AI tooling?
No