Skip to content

Conversation

@mgabelle
Copy link

@mgabelle mgabelle commented Feb 5, 2025

What changes were proposed in this pull request?

PR to address issues related in #20
Changes consist of upgrading to the most recent version of protobuf and protoc.

Why are the changes needed?

Changes needed cause there are possible conflicts with recent protobuf versions from other libraries.
Also the current protobuf version is way out behind the current one and has some vulnerabilities.

How was this patch tested?

No tests, just a build, I don't really know how to correctly test this one.

@github-actions github-actions bot added the BUILD label Feb 5, 2025
@wgtmac
Copy link
Member

wgtmac commented Feb 5, 2025

Is there any risk? This seems to be a huge version bump. @dongjoon-hyun

<maven.compiler.useIncrementalCompilation>false</maven.compiler.useIncrementalCompilation>
<maven.version>3.9.6</maven.version>
<protoc.version>3.17.3</protoc.version>
<protoc.version>4.28.2</protoc.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask why you propose this old version instead of the latest, @mgabelle ?

@dongjoon-hyun
Copy link
Member

Is there any risk? This seems to be a huge version bump. @dongjoon-hyun

Yes, there is a breaking change, @wgtmac . For example, v26 introduced a breaking change to Java API last year. And, this is more higher version than that.

v26.x will break compatibility with generated code from older major versions. Users should regenerate old generated code to be from the same version.
For example, GeneratedMessageV3, which was originally introduced for backwards compatibility with generated code from v2.x.x against v3.x.x runtime, will be renamed to GeneratedMessage. Runtimes will be updated to support Editions, which will not be compatible with old generated code.

@ekpdt
Copy link

ekpdt commented Mar 11, 2025

The solution is to upgrade both protoc and the protobuf runtime to 3.25.6, which is compatible with v26.x without being (as) breaking

diff --git a/pom.xml b/pom.xml
index a0118ac..2b18169 100644
--- a/pom.xml
+++ b/pom.xml
@@ -61,7 +61,7 @@
         <maven.compiler.release>17</maven.compiler.release>
         <maven.compiler.useIncrementalCompilation>false</maven.compiler.useIncrementalCompilation>
         <maven.version>3.9.6</maven.version>
-        <protoc.version>3.17.3</protoc.version>
+        <protoc.version>3.25.6</protoc.version>
         <test.tmp.dir>${project.build.directory}/testing-tmp</test.tmp.dir>
     </properties>
 
@@ -69,7 +69,7 @@
         <dependency>
             <groupId>com.google.protobuf</groupId>
             <artifactId>protobuf-java</artifactId>
-            <version>3.25.1</version>
+            <version>3.25.6</version>
         </dependency>
     </dependencies>

@dongjoon-hyun
Copy link
Member

Since there exists an open PR for 3.25.5, I merged that to address CVE-2024-7254 .

@dongjoon-hyun dongjoon-hyun changed the title ORC-20 - Upgrade protoc and protobuf version ORC-FORMAT-20 - Upgrade protoc and protobuf version Apr 25, 2025
@mgabelle mgabelle closed this by deleting the head repository May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants