Skip to content

feat(bindings/dart): Add dart binding #5591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Mar 10, 2025
Merged

Conversation

asukaminato0721
Copy link
Contributor

@asukaminato0721 asukaminato0721 commented Feb 1, 2025

Which issue does this PR close?

Closes #2435. Use the same way as https://github.com/open-spaced-repetition/fsrs-rs-dart.

Rationale for this change

What changes are included in this PR?

add dart binding

Are there any user-facing changes?

no

@asukaminato0721 asukaminato0721 changed the title init add dart binding Feb 1, 2025
@asukaminato0721 asukaminato0721 marked this pull request as ready for review February 1, 2025 11:23
@asukaminato0721 asukaminato0721 changed the title add dart binding feat(bindings/dart): Add dart binding Feb 1, 2025
@github-actions github-actions bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Feb 1, 2025
@asukaminato0721 asukaminato0721 marked this pull request as draft February 1, 2025 15:37
@asukaminato0721
Copy link
Contributor Author

asukaminato0721 commented Feb 1, 2025

I only ported part of the apis so the test can pass. And currently all result is using unwrap (as a first version).

@asukaminato0721 asukaminato0721 marked this pull request as ready for review February 1, 2025 19:38
@Xuanwo
Copy link
Member

Xuanwo commented Feb 2, 2025

Thank you so much, @asukaminato0721, for working on this. I will start reviewing this PR later next week. Wishing you a wonderful holiday in the meantime!

@asukaminato0721
Copy link
Contributor Author

asukaminato0721 commented Feb 13, 2025

@Xuanwo now it's like drop-in replacement.

await RustLib.init();  
final File = FileManager.initOp(...);
// just add above 2 lines
final f = File("foo.txt");

@asukaminato0721 asukaminato0721 force-pushed the dart-binding branch 2 times, most recently from 96e0456 to d25bb41 Compare February 25, 2025 17:51
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @asukaminato0721 for working on this!

@Xuanwo Xuanwo merged commit 48f1441 into apache:main Mar 10, 2025
34 checks passed
@Xuanwo
Copy link
Member

Xuanwo commented Mar 10, 2025

Hi, @asukaminato0721 would you like to create a tracking issue for the following tasks? I think we need examples, tests, docs and figure how to release it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
releases-note/feat The PR implements a new feature or has a title that begins with "feat"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenDAL Dart/Flutter bindings
2 participants