[BUILD] Downgrade scala-maven-plugin to 4.3.0 #441
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
==========================================
- Coverage 80.62% 80.62% -0.01%
==========================================
Files 101 101
Lines 3706 3705 -1
Branches 451 451
==========================================
- Hits 2988 2987 -1
Misses 485 485
Partials 233 233
Continue to review full report at Codecov.
|
yaooqinn
reviewed
Mar 16, 2021
| <maven.plugin.antrun.version>3.0.0</maven.plugin.antrun.version> | ||
| <maven.plugin.compiler.version>3.8.1</maven.plugin.compiler.version> | ||
| <maven.plugin.scala.version>4.4.0</maven.plugin.scala.version> | ||
| <maven.plugin.scala.version>4.3.0</maven.plugin.scala.version> |
Member
There was a problem hiding this comment.
Need a comment here in case that we bump it up wrong again
yaooqinn
approved these changes
Mar 16, 2021
yaooqinn
pushed a commit
that referenced
this pull request
Mar 16, 2021
 [](https://github.com/yaooqinn/kyuubi/pull/441)     [<img width="16" alt="Powered by Pull Request Badge" src="https://user-images.githubusercontent.com/1393946/111216524-d2bb8e00-85d4-11eb-821b-ed4c00989c02.png">](https://pullrequestbadge.com/?utm_medium=github&utm_source=yaooqinn&utm_campaign=badge_info)<!-- PR-BADGE: PLEASE DO NOT REMOVE THIS COMMENT --> <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html 2. If the PR is related to an issue in https://github.com/yaooqinn/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'. 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'. --> ### _Why are the changes needed?_ <!-- Please clarify why the changes are needed. For instance, 1. If you add a feature, you can talk about the use case of it. 2. If you fix a bug, you can clarify why it is a bug. --> There are several known issues with `scala-maven-plugin:4.4.0` about `zinc`. On CentOS 7, with Oracle JDK 8 installed via RPM, `/bin/java` links to `jdk/jre/bin/java` but `/bin/javac` links to `jdk/bin/javac` ``` [opsbd-ck-uat-30007-vm ~]$ ll -l /bin/java lrwxrwxrwx 1 root root 22 Mar 12 14:03 /bin/java -> /etc/alternatives/java [opsbd-ck-uat-30007-vm ~]$ ll -l /etc/alternatives/java lrwxrwxrwx 1 root root 41 Mar 12 14:03 /etc/alternatives/java -> /usr/java/jdk1.8.0_251-amd64/jre/bin/java [opsbd-ck-uat-30007-vm ~]$ ll -l /bin/javac lrwxrwxrwx 1 root root 23 Mar 12 14:03 /bin/javac -> /etc/alternatives/javac [opsbd-ck-uat-30007-vm ~]$ ll -l /etc/alternatives/javac lrwxrwxrwx 1 root root 38 Mar 12 14:03 /etc/alternatives/javac -> /usr/java/jdk1.8.0_251-amd64/bin/javac ``` when run `build/dist --tgz` cause ``` [ERROR] Failed to execute goal net.alchim31.maven:scala-maven-plugin:4.4.0:testCompile (scala-test-compile-first) on project kyuubi-common: wrap: java.io.IOException: Cannot run program "/usr/java/jdk1.8.0_221-amd64/jre/bin/javac" (in directory "/data/ansible/ci/kyuubi"): error=2, No such file or directory -> [Help 1] ``` And there is another issue reported by Apache Spark: apache/spark#31031 Please also merge it into branch-1.1 ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [x] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/latest/tools/testing.html#running-tests) locally before make a pull request Closes #441 from pan3793/build. 6f6c34d [Cheng Pan] add comments 312b2c5 [Cheng Pan] [BUILD] Downgrade scala-maven-plugin to 4.3.0 Authored-by: Cheng Pan <[email protected]> Signed-off-by: Kent Yao <[email protected]> (cherry picked from commit 794a753) Signed-off-by: Kent Yao <[email protected]>
<!--](https://user-images.githubusercontent.com/1393946/111216524-d2bb8e00-85d4-11eb-821b-ed4c00989c02.png">](https://pullrequestbadge.com/?utm_medium=github&utm_source=yaooqinn&utm_campaign=badge_info)<!--){kind=link}
Member
|
thanks, merged to master for v1.2.0 and branch 1.1 for v1.1.1 |
This was referenced Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
There are several known issues with
scala-maven-plugin:4.4.0aboutzinc.On CentOS 7, with Oracle JDK 8 installed via RPM,
/bin/javalinks tojdk/jre/bin/javabut/bin/javaclinks tojdk/bin/javacwhen run
build/dist --tgzcauseAnd there is another issue reported by Apache Spark: apache/spark#31031
Please also merge it into branch-1.1
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request