Use `uv` as the unified project manager #38

orcahmlee · 2025-12-02T15:28:09Z

Related to #37, this PR had two changes:

9f53c76: The pyproject.toml was updated to use uv. All of the settings were migrated from poetry.
f5258f0: Updated the usage of the uv command for installing and building, and also retained the pip command.

Here are some manual validations I did:

Created a new virtual environment using uv venv and installed the dependencies using uv pip install -e ., uv pip install -e ".[aioldap]" and uv pip install -e ".[test]"
Built the Python package by uv build
Ran the unit test by uv run pytest

orcahmlee · 2025-12-02T15:30:53Z

Hi @gstein , @sbp , @tisonkun

This is the first trial, please give me some advice.

.python-version

pyproject.toml

README.md

shenxiangzhuang · 2025-12-03T02:13:03Z

I think the workflow should also be changed to use uv, now it's still using poetry:

infrastructure-asfquart/.github/workflows/unit-tests.yml

Lines 55 to 57 in 951e30c

    
               - name: Test with pytest 
        
                 run: | 
        
                   poetry run pytest -rA

orcahmlee · 2025-12-03T03:17:12Z

I think the workflow should also be changed to use uv, now it's still using poetry:

infrastructure-asfquart/.github/workflows/unit-tests.yml

Lines 55 to 57 in 951e30c

- name: Test with pytest

run: |

poetry run pytest -rA

Seems the entire workflow using poetry. I need more time to figure out Github Workflows 😢

orcahmlee · 2025-12-03T06:54:17Z

.github/workflows/unit-tests.yml

+          fetch-depth: 0 # need all versions to be able to access server tree commit logs
+          persist-credentials: false
+      - name: Install uv and set the Python version
+        uses: astral-sh/setup-uv@v7


Hi @shenxiangzhuang

Would you mind reviewing this change where I use the uv official actions to set up Python and uv itself.
Ref: https://docs.astral.sh/uv/guides/integration/github/

If we want to keep the original caching behavior, we could try https://github.com/astral-sh/setup-uv/blob/main/docs/caching.md. But if the CI isn't run as often, I think we're good to keep it as is.

orcahmlee · 2025-12-03T06:55:06Z

.github/workflows/unit-tests.yml

+        with:
+          python-version: ${{ matrix.python-version }}
+          enable-cache: true # enable built-in caching of uv
+      - uses: awalsh128/cache-apt-pkgs-action@5902b33ae29014e6ca012c5d8025d4346556bd40 # latest


I think this is not poetry related so I kept it.

.github/workflows/unit-tests.yml

Lee-W · 2025-12-03T07:29:46Z

.github/workflows/unit-tests.yml

+          fetch-depth: 0 # need all versions to be able to access server tree commit logs
+          persist-credentials: false
+      - name: Install uv and set the Python version
+        uses: astral-sh/setup-uv@v7


If we want to keep the original caching behavior, we could try https://github.com/astral-sh/setup-uv/blob/main/docs/caching.md. But if the CI isn't run as often, I think we're good to keep it as is.

README.md

Lee-W · 2025-12-04T03:39:47Z

README.md


 ```shell
-poetry run pytest
+uv sync --group test


Suggested change

uv sync --group test

uv sync --extra aioldap --group test

if the test also cover the extra, this would be needed. If not, we should be good.

Done.
I guess the test should cover all extras including the further extras. Furthermore, since I install all extras during the Action, I think it would be better to maintain consistency in the README.

- name: Install dependencies run: uv sync --locked --all-extras --group test

tisonkun · 2025-12-04T05:01:17Z

@gstein it seems we need a member with write permission on this repo to trigger the CI workflow.

@orcahmlee or else, you can open a PR to your fork with your fork updated to the latest main. Then you can verify the CI workflow on your repo PR as well.

Signed-off-by: Andrew Li <[email protected]>

orcahmlee · 2025-12-04T05:38:21Z

@gstein it seems we need a member with write permission on this repo to trigger the CI workflow.

@orcahmlee or else, you can open a PR to your fork with your fork updated to the latest main. Then you can verify the CI workflow on your repo PR as well.

I've rebased the latest upstream/main then created a PR on my own repo. Perhaps I miss something setting for GitHub Actions, I didn't see the CI workflow.

orcahmlee#1

orcahmlee · 2025-12-04T06:11:52Z

@gstein it seems we need a member with write permission on this repo to trigger the CI workflow.

@orcahmlee or else, you can open a PR to your fork with your fork updated to the latest main. Then you can verify the CI workflow on your repo PR as well.

Manually trigger the CI workflow on my repo. Seems only the test failed in Python 3.14
https://github.com/orcahmlee/infrastructure-asfquart/actions/runs/19919472414/job/57105098829#step:6:102

orcahmlee · 2025-12-06T15:21:51Z

@gstein it seems we need a member with write permission on this repo to trigger the CI workflow.

@orcahmlee or else, you can open a PR to your fork with your fork updated to the latest main. Then you can verify the CI workflow on your repo PR as well.

What should I do next? Should I remove the unit test in Python 3.14?

tisonkun · 2025-12-06T15:36:29Z

@gstein it seems we need a member with write permission on this repo to trigger the CI workflow.
@orcahmlee or else, you can open a PR to your fork with your fork updated to the latest main. Then you can verify the CI workflow on your repo PR as well.

What should I do next? Should I remove the unit test in Python 3.14?

Yes, you can and leave it as a follow up. IIRC Python 3.14 is not included in the test matrix now.

I'll try to give it a review tomorrow and hopefully @gstein would have a look also.

Signed-off-by: Andrew Li <[email protected]>

tisonkun

Generally looks good. I think we have two remaining tasks before this patch gets mergeable:

The Makefile needs to be updated to avoid poetry deps.
I'd prefer a RELEASE.md file to describe how to release asfquart with uv setup so that we can immediately follow up use a 0.1.14 release to verify it. Or you may describe it in this PR first.

Signed-off-by: Andrew Li <[email protected]>

orcahmlee · 2025-12-07T16:19:49Z

Generally looks good. I think we have two remaining tasks before this patch gets mergeable:

The Makefile needs to be updated to avoid poetry deps.

I'd prefer a RELEASE.md file to describe how to release asfquart with uv setup so that we can immediately follow up use a 0.1.14 release to verify it. Or you may describe it in this PR first.

Done

I'm not quite sure what the content of the RELEASE.md should be. If my understanding is correct that I think the release process could be:

uv build
# The source distributions and wheels will be built to the `dist` directory

uv publish
# This command will upload the distributions and wheels in the `dist` directory to the `https://upload.pypi.org/legacy/` index as default
# Pass the username/password or token

If I have misunderstood, could you give some examples?

tisonkun

LGTM.

About RELEASE.md, I suppose @gstein or an INFRA member can try your commands out and once it's verified, we can provide a proper RELEASE.md following any convenient pattern.

orcahmlee · 2025-12-08T01:56:12Z

LGTM.

About RELEASE.md, I suppose @gstein or an INFRA member can try your commands out and once it's verified, we can provide a proper RELEASE.md following any convenient pattern.

@tisonkun , @Lee-W Thanks for your reviews.

gstein · 2025-12-08T07:22:30Z

Thanks for the PR. Very helpful!

tisonkun · 2025-12-08T07:50:30Z

@orcahmlee Thanks for your contribution and continued follow-up!

If you have some spare time and are interested in how ASF organized its "internal" services, you may take a look at Apache STeVe that runs most foundation-wide votings in the ASF. (We'll use it to run the vote in the upcoming membership meetings.)

Besides, you may also dig into why Python 3.14 failed the CI to add its support.

Take these suggestions as advice rather than requests - Just enjoy hacking in the community.

Lee-W reviewed Dec 3, 2025

View reviewed changes

orcahmlee force-pushed the dev/37 branch from f5258f0 to 948d2a4 Compare December 3, 2025 03:08

tisonkun mentioned this pull request Dec 3, 2025

Enable unit tests workflow on pull requests to main branch #39

Merged

orcahmlee commented Dec 3, 2025

View reviewed changes

Lee-W reviewed Dec 3, 2025

View reviewed changes

orcahmlee force-pushed the dev/37 branch from d8de03e to 4ec12e4 Compare December 3, 2025 08:44

Lee-W reviewed Dec 4, 2025

View reviewed changes

orcahmlee force-pushed the dev/37 branch from 4ec12e4 to 8b544d5 Compare December 4, 2025 04:55

build(pyproject.toml): migrated to uv from poetry (apache#37)

8c5b8e9

Signed-off-by: Andrew Li <[email protected]>

orcahmlee force-pushed the dev/37 branch from 8b544d5 to 861cfb2 Compare December 4, 2025 05:30

orcahmlee added 2 commits December 7, 2025 14:16

docs(readme): updated the doc base on the migration to uv (apache#37)

a6d1088

Signed-off-by: Andrew Li <[email protected]>

ci(workflows): migrated the GitHub Actions to uv from poetry (apache#37)

9d9f695

Signed-off-by: Andrew Li <[email protected]>

orcahmlee force-pushed the dev/37 branch from 861cfb2 to 9d9f695 Compare December 7, 2025 06:17

tisonkun reviewed Dec 7, 2025

View reviewed changes

build(Makefile): migrated to uv from poetry (apache#37)

91f9c9d

Signed-off-by: Andrew Li <[email protected]>

tisonkun approved these changes Dec 7, 2025

View reviewed changes

Lee-W approved these changes Dec 8, 2025

View reviewed changes

gstein merged commit db66de6 into apache:main Dec 8, 2025
4 checks passed

tisonkun mentioned this pull request Dec 8, 2025

Use uv as the unified project manager #37

Closed

Use uv as the unified project manager #38

Use uv as the unified project manager #38

Uh oh!

Conversation

orcahmlee commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

orcahmlee commented Dec 2, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shenxiangzhuang commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

orcahmlee commented Dec 3, 2025

Uh oh!

orcahmlee Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Lee-W Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

orcahmlee Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Lee-W Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Lee-W Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

orcahmlee Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

tisonkun commented Dec 4, 2025

Uh oh!

orcahmlee commented Dec 4, 2025

Uh oh!

orcahmlee commented Dec 4, 2025

Uh oh!

orcahmlee commented Dec 6, 2025

Uh oh!

tisonkun commented Dec 6, 2025

Uh oh!

tisonkun left a comment

Choose a reason for hiding this comment

Uh oh!

orcahmlee commented Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tisonkun left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

orcahmlee commented Dec 8, 2025

Uh oh!

Uh oh!

gstein commented Dec 8, 2025

Uh oh!

tisonkun commented Dec 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Use `uv` as the unified project manager #38

Use `uv` as the unified project manager #38

orcahmlee commented Dec 2, 2025 •

edited

Loading

shenxiangzhuang commented Dec 3, 2025 •

edited

Loading

orcahmlee commented Dec 7, 2025 •

edited

Loading

tisonkun left a comment •

edited

Loading