-
Notifications
You must be signed in to change notification settings - Fork 7
Cleanup application construction #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…as an EasyDict, cleanup and document arguments for contruct and ASFQuart.__init__, remove hack for hypercorn
|
I kept |
|
to get a better understanding of the reason for the PR: we certainly want to use Also we at least want to have the option to use multiple workers for the app, and in such a case, using an ASGI server directly is the only option.
I made this distinction also in the README and added a Makefile to showcase how you can run the app in both modes. |
|
I did a small update on the docs, but my changes did not touch anything that is described there. |
This PR does the following changes:
__file__parameter. Also hypercorn now only loads the application in the worker process, see Only load the application in the main process if the reloader is being used. pgjones/hypercorn#143