Skip to content

Conversation

@netomi
Copy link
Member

@netomi netomi commented Apr 4, 2025

This PR does the following changes:

…as an EasyDict, cleanup and document arguments for contruct and ASFQuart.__init__, remove hack for hypercorn
@netomi
Copy link
Member Author

netomi commented Apr 4, 2025

I kept app.cfg around for the time being. If you dont like the idea with the ASFQuartConfig its fine by me.
It just was a bit confusing to have 2 different configs, and you need to think which one to access.

@netomi
Copy link
Member Author

netomi commented Apr 4, 2025

to get a better understanding of the reason for the PR:

we certainly want to use hypercorn to run our applications in production mode and do not want to have any development settings active in such a mode, e.g. reload of the application in case of source or config file changes.

Also we at least want to have the option to use multiple workers for the app, and in such a case, using an ASGI server directly is the only option.

runx is great for development, so that the app restarts itself when something changes, or templates are refreshed. However, for a production service this is not what you want in any case.

I made this distinction also in the README and added a Makefile to showcase how you can run the app in both modes.

@netomi netomi changed the title Cleanup application contruction Cleanup application construction Apr 4, 2025
@dave2wave
Copy link
Member

@netomi Any changes needed to the docs?

@netomi
Copy link
Member Author

netomi commented Apr 4, 2025

I did a small update on the docs, but my changes did not touch anything that is described there.

@netomi netomi merged commit 8e4dc7c into main Apr 14, 2025
4 checks passed
@netomi netomi deleted the remove-hypercorn-workarounds branch April 14, 2025 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants