Skip to content

Enable col-stats by default for 1.1.x hudi version #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vinishjail97 wants to merge 1 commit into
base: hudi-upgrade-version
Choose a base branch
from
+6 −8
Open

Enable col-stats by default for 1.1.x hudi version #778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
<lombok.version>1.18.36</lombok.version>
<lombok-maven-plugin.version>1.18.20.0</lombok-maven-plugin.version>
<hadoop.version>3.4.1</hadoop.version>
<hudi.version>1.1.0</hudi.version>
<hudi.version>1.2.0-SNAPSHOT</hudi.version>
<aws.version>2.29.40</aws.version>
<hive.version>3.1.3</hive.version>
<maven-source-plugin.version>3.3.1</maven-source-plugin.version>
Expand Down
4 changes: 3 additions & 1 deletion xtable-core/src/main/java/org/apache/xtable/hudi/HudiFileStatsExtractor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
import org.apache.parquet.io.api.Binary;

import org.apache.hudi.avro.model.HoodieMetadataColumnStats;
import org.apache.hudi.common.schema.HoodieSchema;
import org.apache.hudi.common.table.HoodieTableMetaClient;
import org.apache.hudi.common.util.Option;
import org.apache.hudi.common.util.ParquetUtils;
Expand Down Expand Up @@ -197,7 +198,8 @@ private HudiFileStats computeColumnStatsForFile(
.filter(
e ->
HoodieTableMetadataUtil.isColumnTypeSupported(
schemaConverter.fromInternalSchema(e.getValue().getSchema()),
HoodieSchema.fromAvroSchema(
schemaConverter.fromInternalSchema(e.getValue().getSchema())),
Option.empty(),
indexVersion))
.map(Map.Entry::getKey)
Expand Down
4 changes: 1 addition & 3 deletions xtable-core/src/test/java/org/apache/xtable/TestAbstractHudiTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,9 +443,7 @@ protected HoodieWriteConfig generateWriteConfig(Schema schema, TypedProperties k
HoodieMetadataConfig metadataConfig =
HoodieMetadataConfig.newBuilder()
.enable(true)
// TODO: Hudi 1.1 MDT col-stats generation fails for array and map types.
// https://github.com/apache/incubator-xtable/issues/773
.withMetadataIndexColumnStats(false)
.withMetadataIndexColumnStats(true)
.withColumnStatsIndexForColumns(getColumnsFromSchema(schema))
.build();
Properties lockProperties = new Properties();
Expand Down
4 changes: 1 addition & 3 deletions xtable-core/src/test/java/org/apache/xtable/hudi/TestHudiFileStatsExtractor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@
import org.apache.parquet.hadoop.ParquetWriter;
import org.apache.parquet.hadoop.util.HadoopOutputFile;
import org.jetbrains.annotations.NotNull;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;

Expand Down Expand Up @@ -134,8 +133,6 @@ public class TestHudiFileStatsExtractor {
.build();

@Test
@Disabled(
"Hudi 1.1 MDT col-stats generation fails for array and map types - https://github.com/apache/incubator-xtable/issues/773")
void columnStatsWithMetadataTable(@TempDir Path tempDir) throws Exception {
String tableName = GenericTable.getTableName();
String basePath;
Expand All @@ -148,6 +145,7 @@ void columnStatsWithMetadataTable(@TempDir Path tempDir) throws Exception {
table.insertRecords(true, records);
basePath = table.getBasePath();
metaClient = table.getMetaClient();
metaClient.reloadTableConfig();
}
HoodieTableMetadata tableMetadata =
new HoodieBackedTableMetadata(
Expand Down