-
Notifications
You must be signed in to change notification settings - Fork 82
feat(java,info): add prefix for adj/pg and add datatype parser test #820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #820 +/- ##
============================================
+ Coverage 77.18% 77.22% +0.04%
- Complexity 607 615 +8
============================================
Files 85 84 -1
Lines 8858 8866 +8
Branches 1043 1047 +4
============================================
+ Hits 6837 6847 +10
+ Misses 1781 1779 -2
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@shivendra-dev54 , thank you again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements default prefix generation for AdjacentList and PropertyGroup when parsing YAML files (addressing issue #814), and adds a test for date/timestamp datatype parsing.
Key changes:
- AdjacentListYaml now generates a default prefix using the adjacency list type name when prefix is null or empty
- PropertyGroupYaml now generates a default prefix by concatenating property names when prefix is null or empty
- New test added to verify date and timestamp data types can be loaded and serialized correctly
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| maven-projects/info/src/main/java/org/apache/graphar/info/yaml/PropertyGroupYaml.java | Adds default prefix generation by concatenating property names with underscores |
| maven-projects/info/src/main/java/org/apache/graphar/info/yaml/AdjacentListYaml.java | Adds default prefix generation using adjacency list type name |
| maven-projects/info/src/test/java/org/apache/graphar/info/PropertyTest.java | Adds test for date/timestamp datatype YAML parsing and imports required classes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
maven-projects/info/src/main/java/org/apache/graphar/info/yaml/PropertyGroupYaml.java
Show resolved
Hide resolved
maven-projects/info/src/main/java/org/apache/graphar/info/yaml/PropertyGroupYaml.java
Outdated
Show resolved
Hide resolved
maven-projects/info/src/test/java/org/apache/graphar/info/PropertyTest.java
Show resolved
Hide resolved
maven-projects/info/src/main/java/org/apache/graphar/info/yaml/PropertyGroupYaml.java
Show resolved
Hide resolved
maven-projects/info/src/test/java/org/apache/graphar/info/PropertyTest.java
Show resolved
Hide resolved
|
@yangxk1 |
I think you will be interested in this email https://lists.apache.org/thread/ydzor82fxlpj7v91kln9z4gt5o33p1b2 |
Reason for this PR
close #814
What changes are included in this PR?
Are these changes tested?
yes
Are there any user-facing changes?
yes