Skip to content

Conversation

@Thespica
Copy link
Contributor

Proposed changes

This PR is still working in progress, and need some discussion about implementation.

  • source code
  • documentation
  • unit test

Besides, should make scala library align, with another PR(this PR does not include this work).

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Related issue #276
Related discussion #379

@Thespica Thespica marked this pull request as draft March 11, 2024 14:47
@SemyonSinchenko
Copy link
Member

spark-graphar module contains also some scala stuff, like Utils, Write/Read, etc. Maybe let's put the new API into a separate sub-module? Like graphar-info?

@acezen
Copy link
Contributor

acezen commented Mar 12, 2024

spark-graphar module contains also some scala stuff, like Utils, Write/Read, etc. Maybe let's put the new API into a separate sub-module? Like graphar-info?

I'm not sure what's left in spark-graphar if we separating the Write/Read to a sub-module? We can open a discussion to discuss the detail of the proposal.

@acezen acezen marked this pull request as ready for review March 12, 2024 02:44
@acezen acezen changed the title [WIP][Spark] Replace Spark Info implementation with JAVA package [Spark] Replace Spark Info implementation with JAVA package(initialization) Mar 12, 2024
@acezen acezen merged commit 4cea0e6 into apache:spark-java-refactoring Mar 12, 2024
acezen pushed a commit that referenced this pull request Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants