Skip to content

Conversation

@Fokko
Copy link
Contributor

@Fokko Fokko commented Dec 18, 2024

And add some nice .to conversions. Feel free to roast my Rust code 👍

@Fokko Fokko force-pushed the fd-add-above-max branch 8 times, most recently from 4e686bb to b315785 Compare December 18, 2024 11:31
And add some nice `.to` conversions.
Fokko added a commit to Fokko/iceberg-rust that referenced this pull request Dec 18, 2024
Fokko added a commit to Fokko/iceberg-rust that referenced this pull request Dec 18, 2024
Fokko added a commit to Fokko/iceberg-rust that referenced this pull request Dec 18, 2024
Fokko added a commit to Fokko/iceberg-rust that referenced this pull request Dec 18, 2024
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Fokko, I love the detailed tests.

@Xuanwo Xuanwo merged commit e1f24c1 into apache:main Dec 20, 2024
32 checks passed
@Fokko Fokko deleted the fd-add-above-max branch December 20, 2024 14:05
sungwy added a commit to sungwy/iceberg-rust that referenced this pull request Dec 20, 2024
Xuanwo pushed a commit that referenced this pull request Dec 20, 2024
* add updated changelog for 0.4.0rc3

* leave out #820
sungwy added a commit that referenced this pull request Dec 20, 2024
* add updated changelog for 0.4.0rc3

* leave out #820
liurenjie1024 pushed a commit that referenced this pull request Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants