Skip to content

Conversation

@liurenjie1024
Copy link
Contributor

This pr introduces an integration test framework which utilizes sqllogictest-rs to build data driven test cases.

@liurenjie1024 liurenjie1024 marked this pull request as draft August 24, 2024 10:45
@ZENOTME
Copy link
Contributor

ZENOTME commented Nov 20, 2024

Thanks @liurenjie1024! This PR is great. After #349, I can also help to migrate our e2e test using this test framework. It's helpful for us to test using different query engines or SDKs. #349 (comment)

@liurenjie1024
Copy link
Contributor Author

Thanks @liurenjie1024! This PR is great. After #349, I can also help to migrate our e2e test using this test framework. It's helpful for us to test using different query engines or SDKs. #349 (comment)

Yeah, I'll find time to split this pr into smaller part to merge them.

Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have one integration-test (with spark) data datafusion-integration-test. They seem to overlap to some extent. Perhaps we can decide to all in one of them in the future.

@liurenjie1024
Copy link
Contributor Author

We already have one integration-test (with spark) data datafusion-integration-test. They seem to overlap to some extent. Perhaps we can decide to all in one of them in the future.

Yes, the goal of this framework is to simplify those integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants