refactor: Move equality-ids closer to the spec #1705
Merged
+51
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
force-pushed
the
fd-equality-ids
branch
4 times, most recently
from
a638bc1 to
3c094c5
Compare
Right now the equality-deletes can't be not-null, while the spec states that it should be null in the case of a manifest-entry that's not an equality delete.
Fokko
force-pushed
the
fd-equality-ids
branch
from
3c094c5 to
24232aa
Compare
CTTY
pushed a commit
to CTTY/iceberg-rust
that referenced
this pull request
Sep 23, 2025
## Which issue does this PR close? Right now the equality-deletes can't be not-null, while the spec states that it should be null in the case of a manifest-entry that's not an equality delete: <img width="835" height="341" alt="image" src="https://github.com/user-attachments/assets/60a88f37-7c50-48b7-8878-ecfe4bd70509" /> ## What changes are included in this PR? <!-- Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates. --> ## Are these changes tested? <!-- Specify what test covers (unit test, integration test, etc.). If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> (cherry picked from commit 921f389)
liurenjie1024
pushed a commit
that referenced
this pull request
Sep 24, 2025
## Which issue does this PR close? - A part of #1631 ## What changes are included in this PR? - Updated change log Verified dependencies list using commands: `python3 ./scripts/dependencies.py generate` and `python3 ./scripts/dependencies.py check`, no dependencies list update is needed after cherry-picking #1705 to my temp release branch: https://github.com/CTTY/iceberg-rust/commits/ctty/070-release/ ## Are these changes tested?
CTTY
added a commit
to CTTY/iceberg-rust
that referenced
this pull request
Sep 24, 2025
…1707) ## Which issue does this PR close? - A part of apache#1631 ## What changes are included in this PR? - Updated change log Verified dependencies list using commands: `python3 ./scripts/dependencies.py generate` and `python3 ./scripts/dependencies.py check`, no dependencies list update is needed after cherry-picking apache#1705 to my temp release branch: https://github.com/CTTY/iceberg-rust/commits/ctty/070-release/ ## Are these changes tested? (cherry picked from commit 6e04443)
sgrebnov
pushed a commit
to spiceai/iceberg-rust
that referenced
this pull request
Sep 25, 2025
## Which issue does this PR close? Right now the equality-deletes can't be not-null, while the spec states that it should be null in the case of a manifest-entry that's not an equality delete: <img width="835" height="341" alt="image" src="https://github.com/user-attachments/assets/60a88f37-7c50-48b7-8878-ecfe4bd70509" /> ## What changes are included in this PR? <!-- Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates. --> ## Are these changes tested? <!-- Specify what test covers (unit test, integration test, etc.). If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? -->
10 tasks
DerGut
pushed a commit
to DerGut/iceberg-rust
that referenced
this pull request
Oct 6, 2025
…1707) ## Which issue does this PR close? - A part of apache#1631 ## What changes are included in this PR? - Updated change log Verified dependencies list using commands: `python3 ./scripts/dependencies.py generate` and `python3 ./scripts/dependencies.py check`, no dependencies list update is needed after cherry-picking apache#1705 to my temp release branch: https://github.com/CTTY/iceberg-rust/commits/ctty/070-release/ ## Are these changes tested?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Right now the equality-deletes can't be not-null, while the spec states that it should be null in the case of a manifest-entry that's not an equality delete:
What changes are included in this PR?
Are these changes tested?