Add LICENSE and NOTICE files for pyiceberg-core source distribution and wheel

[sumanth-manchala]

Which issue does this PR close?

• None.

What changes are included in this PR?

This adds LICENSE and NOTICE files to the PyPI sdist which is needed for distributing conda package. Also add those files to the wheel distribution

Are these changes tested?

[kevinjqliu]

i see in https://pypi.org/project/pyiceberg-core/ the metadata already mentions

License: Apache Software License

am i missing something?

[sumanth-manchala]

i see in https://pypi.org/project/pyiceberg-core/ the metadata already mentions

License: Apache Software License

am i missing something?

Conda forge recommends LICENSE files to be available as part of sdist for re-distribution as conda packages

[kevinjqliu]

Great catch! Having the LICENSE and NOTICE in the artifacts is a requirement for every ASF release, lets fix this asap
https://www.apache.org/legal/release-policy.html#licensing-documentation

Could you also include the NOTICE file in this change?

[kevinjqliu]

cc @Fokko @liurenjie1024 @Xuanwo
we dont have LICENSE and NOTICE file included in past pyiceberg-core releases

[kevinjqliu]

Quick command check for LICENSE and NOTICE file when building sdist and wheel using main branch.

sdist

maturin sdist -o dist        
tar -tzf dist/pyiceberg_core-*.tar.gz | grep -E '/(LICENSE|NOTICE)$'

pyiceberg_core-0.6.0/crates/integrations/datafusion/LICENSE
pyiceberg_core-0.6.0/crates/integrations/datafusion/NOTICE
pyiceberg_core-0.6.0/crates/iceberg/LICENSE
pyiceberg_core-0.6.0/crates/iceberg/NOTICE

LICENSE and NOTICE should be in top-level here.

wheel

maturin build --release -o dist
tar -tzf dist/pyiceberg_core-*.whl | grep -E '/(LICENSE|NOTICE)$'

No LICENSE and NOTICE at all

[sumanth-manchala]

Great catch! Having the LICENSE and NOTICE in the artifacts is a requirement for every ASF release, lets fix this asap https://www.apache.org/legal/release-policy.html#licensing-documentation

Could you also include the NOTICE file in this change?

Done and verified the same in both sdit and whl!

[kevinjqliu]

LGTM!

I verified locally for both sdist and wheel

maturin sdist -o dist        
tar -tzf dist/pyiceberg_core-*.tar.gz | grep -E '/(LICENSE|NOTICE)$'

pyiceberg_core-0.6.0/crates/iceberg/LICENSE
pyiceberg_core-0.6.0/crates/iceberg/NOTICE
pyiceberg_core-0.6.0/crates/integrations/datafusion/LICENSE
pyiceberg_core-0.6.0/crates/integrations/datafusion/NOTICE
pyiceberg_core-0.6.0/bindings/python/LICENSE
pyiceberg_core-0.6.0/bindings/python/NOTICE
pyiceberg_core-0.6.0/LICENSE
pyiceberg_core-0.6.0/NOTICE

maturin build --release -o dist
tar -tzf dist/pyiceberg_core-*.whl | grep -E '/(LICENSE|NOTICE)$'

pyiceberg_core-0.6.0.dist-info/licenses/LICENSE
pyiceberg_core-0.6.0.dist-info/licenses/NOTICE

Pasting the ASF policy,

For source packages, LICENSE and NOTICE MUST be located at the root of the distribution. For additional packages, they MUST be located in the distribution format's customary location for licensing materials, such as the META-INF directory of Java "jar" files.

source package is located at the root.
wheel package is in the licenses/ folder

[kevinjqliu]

CI issue should be resolved by #1654

[sumanth-manchala]

LGTM!

I verified locally for both sdist and wheel

maturin sdist -o dist        
tar -tzf dist/pyiceberg_core-*.tar.gz | grep -E '/(LICENSE|NOTICE)$'

pyiceberg_core-0.6.0/crates/iceberg/LICENSE
pyiceberg_core-0.6.0/crates/iceberg/NOTICE
pyiceberg_core-0.6.0/crates/integrations/datafusion/LICENSE
pyiceberg_core-0.6.0/crates/integrations/datafusion/NOTICE
pyiceberg_core-0.6.0/bindings/python/LICENSE
pyiceberg_core-0.6.0/bindings/python/NOTICE
pyiceberg_core-0.6.0/LICENSE
pyiceberg_core-0.6.0/NOTICE

maturin build --release -o dist
tar -tzf dist/pyiceberg_core-*.whl | grep -E '/(LICENSE|NOTICE)$'

pyiceberg_core-0.6.0.dist-info/licenses/LICENSE
pyiceberg_core-0.6.0.dist-info/licenses/NOTICE

Pasting the ASF policy,

For source packages, LICENSE and NOTICE MUST be located at the root of the distribution. For additional packages, they MUST be located in the distribution format's customary location for licensing materials, such as the META-INF directory of Java "jar" files.

source package is located at the root.
wheel package is in the licenses/ folder

Thanks @kevinjqliu !!

[liurenjie1024]

Thanks @sumanth-manchala for adding this!

[kevinjqliu]

Thanks again @sumanth-manchala and thanks for the review @liurenjie1024