Try infer file io scheme from metadata location ahead of warehouse path #1590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liurenjie1024
approved these changes
Aug 8, 2025
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @daiyy for this pr!
Yiyang-C
pushed a commit
to Yiyang-C/iceberg-rust
that referenced
this pull request
Aug 26, 2025
…th (apache#1590) ## Which issue does this PR close? - Closes apache#1589 ## What changes are included in this PR? As S3Tables REST endpoint accept `warehouse` only in ARN format, Current code logic will infer file io scheme through `warehouse_path` in ARN format as `arn` which is wrong and unable to be processed. Changed the code logic to try infer file io scheme with `metadata_location` before `warehouse_path`, This makes file io scheme infer as `s3` correctly. ## Are these changes tested? Test only in `load_table` path for rest catalog implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
As S3Tables REST endpoint accept
warehouseonly in ARN format,Current code logic will infer file io scheme through
warehouse_pathin ARN format asarnwhich is wrong and unable to be processed.Changed the code logic to try infer file io scheme with
metadata_locationbeforewarehouse_path,This makes file io scheme infer as
s3correctly.Are these changes tested?
Test only in
load_tablepath for rest catalog implementation