Refactor: use metadatalocaiton:new_with_table_location in catalog create_table #1558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yingjianwu98
changed the title
liurenjie1024
approved these changes
Jul 29, 2025
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @stevie9868 for this pr, LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1555
What changes are included in this PR?
Make
create_tableoperation in all the following catalogs Glue, HMS,S3Table,Sql to use MetadataLocation::new_with_table_location when creating the metadata_locationsNote looks like previously the sqlCatalog generates a wrong format of the metadata.json where it does not padding with 5 zero for the first metadata.json and instead it just pad one 0.
Are these changes tested?
Existing tests