Skip to content

fix: retain metadata_location from StaticTable::into_table #1536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025
Merged

fix: retain metadata_location from StaticTable::into_table #1536

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions crates/iceberg/src/table.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,14 +271,23 @@ impl StaticTable {
}
/// Creates a static table directly from metadata file and `FileIO`
pub async fn from_metadata_file(
metadata_file_path: &str,
metadata_location: &str,
table_ident: TableIdent,
file_io: FileIO,
) -> Result<Self> {
let metadata_file = file_io.new_input(metadata_file_path)?;
let metadata_file = file_io.new_input(metadata_location)?;
let metadata_file_content = metadata_file.read().await?;
let table_metadata = serde_json::from_slice::<TableMetadata>(&metadata_file_content)?;
Self::from_metadata(table_metadata, table_ident, file_io).await
let metadata = serde_json::from_slice::<TableMetadata>(&metadata_file_content)?;

let table = Table::builder()
.metadata(metadata)
.metadata_location(metadata_location)
.identifier(table_ident)
.file_io(file_io.clone())
.readonly(true)
.build();

Ok(Self(table?))
}

/// Create a TableScanBuilder for the static table.
Expand Down Expand Up @@ -356,6 +365,10 @@ mod tests {
let table = static_table.into_table();
assert!(table.readonly());
assert_eq!(table.identifier.name(), "static_table");
assert_eq!(
table.metadata_location(),
Some(metadata_file_path).as_deref()
);
}

#[tokio::test]
Expand Down
Loading