Skip to content

Incremental Append Scan #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hililiwei wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Incremental Append Scan #533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ade073
Refactor inheritance relationship
hililiwei Mar 19, 2024
0066b3b
move to snapshot
hililiwei Apr 30, 2024
38d8b1e
handler to_snapshot_id is None
hililiwei Jul 2, 2024
3b5644b
change FileScanTask to ScanTask
hililiwei Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions dev/provision.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,3 +389,45 @@
VALUES (4)
"""
)

spark.sql(
f"""
CREATE OR REPLACE TABLE {catalog_name}.default.test_table_read_from_snapshots (
dt date,
number integer,
letter string
)
USING iceberg
TBLPROPERTIES (
'format-version'='2'
);
"""
)

spark.sql(
f"""
INSERT INTO {catalog_name}.default.test_table_read_from_snapshots
VALUES (CAST('2022-03-01' AS date), 1, 'a')
"""
)

spark.sql(
f"""
INSERT INTO {catalog_name}.default.test_table_read_from_snapshots
VALUES (CAST('2022-03-01' AS date), 2, 'b')
"""
)

spark.sql(
f"""
INSERT INTO {catalog_name}.default.test_table_read_from_snapshots
VALUES (CAST('2022-03-02' AS date), 3, 'c')
"""
)

spark.sql(
f"""
INSERT INTO {catalog_name}.default.test_table_read_from_snapshots
VALUES (CAST('2022-03-02' AS date), 4, 'd')
"""
)
8 changes: 8 additions & 0 deletions pyiceberg/manifest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,6 +551,14 @@ class ManifestFile(Record):
def __init__(self, *data: Any, **named_data: Any) -> None:
super().__init__(*data, **{"struct": MANIFEST_LIST_FILE_STRUCTS[DEFAULT_READ_VERSION], **named_data})

def __eq__(self, other: Any) -> bool:
"""Return the equality of two instances of the ManifestFile class."""
return self.manifest_path == other.manifest_path if isinstance(other, ManifestFile) else False

def __hash__(self) -> int:
"""Return the hash of manifest_path."""
return hash(self.manifest_path)

def has_added_files(self) -> bool:
return self.added_files_count is None or self.added_files_count > 0

Expand Down
Loading