Skip to content

Fix renames of tpep_pickup_datetime → tpep_pickup_day #2496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2025
Merged

Fix renames of tpep_pickup_datetime → tpep_pickup_day #2496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/avro/test_reader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ def test_read_header(generated_manifest_entry_file: str, iceberg_manifest_entry_
{
"field-id": 1001,
"default": None,
"name": "tpep_pickup_datetime",
"name": "tpep_pickup_day",
"type": ["null", {"type": "int", "logicalType": "date"}],
},
],
Expand Down
6 changes: 3 additions & 3 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1178,7 +1178,7 @@ def metadata_location_gz(tmp_path_factory: pytest.TempPathFactory) -> str:
"data_file": {
"file_path": "/home/iceberg/warehouse/nyc/taxis_partitioned/data/VendorID=null/00000-633-d8a4223e-dc97-45a1-86e1-adaba6e8abd7-00001.parquet",
"file_format": "PARQUET",
"partition": {"VendorID": 1, "tpep_pickup_datetime": 1925},
"partition": {"VendorID": 1, "tpep_pickup_day": 1925},
"record_count": 19513,
"file_size_in_bytes": 388872,
"block_size_in_bytes": 67108864,
Expand Down Expand Up @@ -1677,7 +1677,7 @@ def avro_schema_manifest_entry() -> Dict[str, Any]:
{
"field-id": 1001,
"default": None,
"name": "tpep_pickup_datetime",
"name": "tpep_pickup_day",
"type": ["null", {"type": "int", "logicalType": "date"}],
},
],
Expand Down Expand Up @@ -1969,7 +1969,7 @@ def iceberg_manifest_entry_schema() -> Schema:
),
NestedField(
field_id=1001,
name="tpep_pickup_datetime",
name="tpep_pickup_day",
field_type=DateType(),
required=False,
),
Expand Down