Skip to content

Conversation

@Fokko
Copy link
Contributor

@Fokko Fokko commented May 14, 2025

Rationale for this change

This replaces the Cython implementation for reading Avro with Iceberg-Rust. This would greatly simplify the PyIceberg project since we don't have to publish Python wheels anymore.

Are these changes tested?

Are there any user-facing changes?

@Fokko Fokko changed the title Fd rust Use Iceberg-Rust for parsing the ManifestList and Manifests May 15, 2025
@Fokko
Copy link
Contributor Author

Fokko commented Jun 26, 2025

@roeap Thanks, your patch fixed correctly passing through the 102: partition field 🥳

Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we're waiting for apache/iceberg-rust#1328 to finalize, which is dependent on apache/iceberg-rust#1482 :)

@yogevyuval
Copy link

@Fokko This is awesome! thanks for your work on this one.
Do we expect any performance/memory differences with reading it with the rust module?

@Fokko
Copy link
Contributor Author

Fokko commented Jul 8, 2025

@yogevyuval Thanks for asking, and yes, I do expect performance impact since just a part of the deserialization is cythonized. With this change, much more is pushed into Rust. This will also reduce the GIL pressure since we don't have to build the readers anymore :)

I left this PR small to focus on the essentials, but once this is in, we can also clean up a LOT of code 👍

@yogevyuval
Copy link

@yogevyuval Thanks for asking, and yes, I do expect performance impact since just a part of the deserialization is cythonized. With this change, much more is pushed into Rust. This will also reduce the GIL pressure since we don't have to build the readers anymore :)

I left this PR small to focus on the essentials, but once this is in, we can also clean up a LOT of code 👍

Interesting, we have quite a bit of concurrency going on so curious to see the results. Once apache/iceberg-rust#1328 gets merged and release i'll try and create some basic benchmarks and share the results

@yogevyuval
Copy link

For documentation - I tested out 0.7rc and in a manifest with 50K entries the new rust version in python took more than 2X than the original version. I'm not sure if that's because a different parsing strategy (laziness) as @Fokko suggested, or something regarding objects transefrring from rust to python, but I think we should investigate before merging, as this code path is already one of the slowest in pyiceberg

@Fokko
Copy link
Contributor Author

Fokko commented Oct 21, 2025

@yogevyuval That's not good news, but thanks for checking 👍 I agree that we should find out what's going on before merging this. Thanks for doing some testing, that's very much appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants