feat: add metadata updates and requirements interface #257
Conversation
gty404
force-pushed
the
table-metadata
branch
4 times, most recently
from
537df38 to
b147683
Compare
This commit introduces the metadata update and update requirements system for table metadata modifications.
gty404
force-pushed
the
table-metadata
branch
from
b147683 to
d76a780
Compare
gty404
changed the title
| return input; | ||
| } | ||
|
|
||
| static bool EqualsIgnoreCase(const std::string& a, const std::string& b) { |
There was a problem hiding this comment.
nit: We have some operator== definitions that use lhs/rhs as the parameters names, should we follow the same convention here?
| table.cc | ||
| table_metadata.cc | ||
| table_properties.cc | ||
| table_requirement.cc |
There was a problem hiding this comment.
I guess you should also add these files to meson.build.
There was a problem hiding this comment.
+1
Perhaps the CI does not fail because the file is not referenced by others.
|
While I know both WDYT? @Fokko @liurenjie1024 |
Thanks @wgtmac for pinging me. I prefer to add an prefix to improve readability. |
6 participants
This commit introduces the metadata update and update requirements system for table metadata modifications.