-
Notifications
You must be signed in to change notification settings - Fork 982
Demo for Java 22+ Async SPNEGO breakage #744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
stoty
wants to merge
13
commits into
apache:master
Choose a base branch
from
stoty:HTTPCLIENT-2402
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix GSSCredential handling
…or non-compliant servers
Update some debug/exception messages
set isConnectionBased() to false fix logic in needsAuthentication()
This is just a first cut that adds tests to demonstrate the problem This is on top of HTTPCLIENT-2358 as the necessary SPNEGO tests are added there.
1ee4155 to
9737020
Compare
Member
|
@stoty Is this how the problem manifests itself? |
Contributor
Author
|
Yes, @ok2c . |
Contributor
Author
|
AsyncDirectHttp1Spnego still succeeds, because it doesn't rely on getting the Subject from the Thread JAAS Scope. So SPNEGO in general still works with Async as long the Principal is explicitly set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress
Needs JDK 25 installed and configured in maven toolchains
Run
mvn clean verify -Pdocker -Drat.skip -Dcheckstyle.skip -Dit.test=ApacheHTTPDSquidCompatibilityIT\* -Dsurefire.failIfNoSpecifiedTests=false -Dtest=footo demonstrate the problem.
The test fails when running the test with Java 25, but passes with 17.