HDDS-1645 Change the version of Pico CLI to the latest 3.x release - 3.9.6 #909

sodonnel · 2019-06-05T09:42:47Z

The version of Pico CLI used in the project is 3.5.2. The current stable release is 3.9.6 and it supports some good new features, such as being able to create sub-commands as methods rather than standalone classes.

We should increase the Pico CLI version in the project pom.xml to 3.9.6 to take advantage of these new features as the CLI code is refactored to use Pico CLI, such as in HDDS-1622.

…lease on the 3.x branch

elek · 2019-06-05T09:51:46Z

/label ozone

hadoop-yetus · 2019-06-05T11:11:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	32	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	505	trunk passed
+1	compile	299	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	1592	branch has no errors when building and testing our client artifacts.
+1	javadoc	179	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	463	the patch passed
+1	compile	303	the patch passed
+1	javac	303	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	1	The patch has no ill-formed XML file.
+1	shadedclient	667	patch has no errors when building and testing our client artifacts.
+1	javadoc	181	the patch passed
		_ Other Tests _
+1	unit	233	hadoop-hdds in the patch passed.
-1	unit	1318	hadoop-ozone in the patch failed.
+1	asflicense	58	The patch does not generate ASF License warnings.
		5234

Reason	Tests
Failed junit tests	hadoop.ozone.TestMiniOzoneCluster
	hadoop.ozone.ozShell.TestOzoneShell

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-909/1/artifact/out/Dockerfile
GITHUB PR	#909
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml
uname	Linux 45ff34a0085d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 433e97c
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-909/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-909/1/testReport/
Max. process+thread count	4564 (vs. ulimit of 5500)
modules	C: hadoop-hdds U: hadoop-hdds
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-909/1/console
versions	git=2.7.4 maven=3.3.9
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

elek

+1 pending jenkins (unit-tests)

Thanks @sodonnel the version bump.

Acceptance test failures (which are invisible because HDDS-1628 #902) are unrelated (auditlog test will be fixed by HDDS-1630 #888)

elek · 2019-06-05T12:42:34Z

The failure of TestOzoneShell seems to be related:

java.lang.AssertionError: Error of shell code doesn't contain the exception [For input string: "invalid-length"] in [Invalid value for option '--length': 'invalid-length' is not an int]
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.apache.hadoop.ozone.ozShell.TestOzoneShell.executeWithError(TestOzoneShell.java:464)
	at org.apache.hadoop.ozone.ozShell.TestOzoneShell.testListVolume(TestOzoneShell.java:634)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)

I think the default error message is changed and the assertion should be updated. Can you please fix this?

…ew error message return from Pico CLI

sodonnel · 2019-06-05T16:15:17Z

You are correct, the error message returned by Pico CLI seems to have been enhanced causing TestOzoneShell.testListVolume() to fail. I have fixed the test and re-tested locally so I will push the changes in a few minutes.

hadoop-yetus · 2019-06-05T18:15:37Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	33	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	66	Maven dependency ordering for branch
+1	mvninstall	503	trunk passed
+1	compile	287	trunk passed
+1	checkstyle	90	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	890	branch has no errors when building and testing our client artifacts.
+1	javadoc	181	trunk passed
0	spotbugs	330	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	517	trunk passed
		_ Patch Compile Tests _
0	mvndep	36	Maven dependency ordering for patch
+1	mvninstall	467	the patch passed
+1	compile	305	the patch passed
+1	javac	305	the patch passed
+1	checkstyle	75	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	1	The patch has no whitespace issues.
+1	xml	2	The patch has no ill-formed XML file.
+1	shadedclient	688	patch has no errors when building and testing our client artifacts.
+1	javadoc	153	the patch passed
+1	findbugs	543	the patch passed
		_ Other Tests _
+1	unit	226	hadoop-hdds in the patch passed.
-1	unit	1665	hadoop-ozone in the patch failed.
+1	asflicense	49	The patch does not generate ASF License warnings.
		6950

Reason	Tests
Failed junit tests	hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion
	hadoop.ozone.client.rpc.TestFailureHandlingByClient
	hadoop.hdds.scm.pipeline.TestSCMPipelineManager

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-909/2/artifact/out/Dockerfile
GITHUB PR	#909
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle
uname	Linux 6272fdf82795 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `0b1e288`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-909/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-909/2/testReport/
Max. process+thread count	5007 (vs. ulimit of 5500)
modules	C: hadoop-hdds hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-909/2/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

elek

+1 LGTM. Thanks to update. Will merge it soon...

elek · 2019-06-06T14:20:24Z

Merged. Thanks @sodonnel the contribution.

Support for empty records

Changed the Pico CLI version to 3.9.6, which is the current latest re…

32644aa

…lease on the 3.x branch

elek self-requested a review June 5, 2019 09:52

elek added the ozone label Jun 5, 2019

elek approved these changes Jun 5, 2019

View reviewed changes

Changed assertion in TestOzoneShell.testListVolume() to reflect the n…

4856cd8

…ew error message return from Pico CLI

elek approved these changes Jun 6, 2019

View reviewed changes

elek closed this in 36757ad Jun 6, 2019

shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019

Merge pull request apache#909 from srinipunuru/emptyrecords.1

2619f64

Support for empty records

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDDS-1645 Change the version of Pico CLI to the latest 3.x release - 3.9.6 #909

HDDS-1645 Change the version of Pico CLI to the latest 3.x release - 3.9.6 #909

Uh oh!

sodonnel commented Jun 5, 2019

Uh oh!

elek commented Jun 5, 2019

Uh oh!

hadoop-yetus commented Jun 5, 2019

Uh oh!

elek left a comment

Uh oh!

elek commented Jun 5, 2019

Uh oh!

sodonnel commented Jun 5, 2019

Uh oh!

hadoop-yetus commented Jun 5, 2019

Uh oh!

elek left a comment

Uh oh!

elek commented Jun 6, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HDDS-1645 Change the version of Pico CLI to the latest 3.x release - 3.9.6 #909

HDDS-1645 Change the version of Pico CLI to the latest 3.x release - 3.9.6 #909

Uh oh!

Conversation

sodonnel commented Jun 5, 2019

Uh oh!

elek commented Jun 5, 2019

Uh oh!

hadoop-yetus commented Jun 5, 2019

Uh oh!

elek left a comment

Choose a reason for hiding this comment

Uh oh!

elek commented Jun 5, 2019

Uh oh!

sodonnel commented Jun 5, 2019

Uh oh!

hadoop-yetus commented Jun 5, 2019

Uh oh!

elek left a comment

Choose a reason for hiding this comment

Uh oh!

elek commented Jun 6, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants