HDDS-1608. Support Ozone Prefix ACLs in OM metadata table. Contribute… #875

xiaoyuyao · 2019-05-30T18:14:26Z

No description provided.

…d by Xiaoyu Yao.

bharatviswa504

One minor comment, the Test file is missing Apache license header.
Overall patch LGTM. +1, with that, addressed.

hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/codec/TestOmPrefixInfoCodec.java

bharatviswa504

+1 LGTM. Pending CI.

hadoop-yetus · 2019-05-30T21:12:28Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	31	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	19	Maven dependency ordering for branch
+1	mvninstall	583	trunk passed
+1	compile	273	trunk passed
+1	checkstyle	77	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	921	branch has no errors when building and testing our client artifacts.
+1	javadoc	154	trunk passed
0	spotbugs	304	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	500	trunk passed
		_ Patch Compile Tests _
0	mvndep	20	Maven dependency ordering for patch
+1	mvninstall	479	the patch passed
+1	compile	277	the patch passed
+1	cc	277	the patch passed
+1	javac	277	the patch passed
-0	checkstyle	41	hadoop-ozone: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	725	patch has no errors when building and testing our client artifacts.
+1	javadoc	149	the patch passed
+1	findbugs	542	the patch passed
		_ Other Tests _
+1	unit	234	hadoop-hdds in the patch passed.
-1	unit	1446	hadoop-ozone in the patch failed.
+1	asflicense	49	The patch does not generate ASF License warnings.
		6747

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
	hadoop.ozone.client.rpc.TestBlockOutputStream
	hadoop.ozone.client.rpc.TestCommitWatcher

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-875/1/artifact/out/Dockerfile
GITHUB PR	#875
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname	Linux 29913530280b 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `f1552f6`
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-875/1/artifact/out/diff-checkstyle-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-875/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-875/1/testReport/
Max. process+thread count	5355 (vs. ulimit of 5500)
modules	C: hadoop-ozone/common hadoop-ozone/ozone-manager U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-875/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-05-30T21:25:11Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	29	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	12	Maven dependency ordering for branch
+1	mvninstall	541	trunk passed
+1	compile	283	trunk passed
+1	checkstyle	89	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	908	branch has no errors when building and testing our client artifacts.
+1	javadoc	161	trunk passed
0	spotbugs	304	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	495	trunk passed
		_ Patch Compile Tests _
0	mvndep	27	Maven dependency ordering for patch
+1	mvninstall	502	the patch passed
+1	compile	274	the patch passed
+1	cc	274	the patch passed
+1	javac	274	the patch passed
-0	checkstyle	38	hadoop-ozone: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	656	patch has no errors when building and testing our client artifacts.
+1	javadoc	148	the patch passed
+1	findbugs	494	the patch passed
		_ Other Tests _
+1	unit	238	hadoop-hdds in the patch passed.
-1	unit	1276	hadoop-ozone in the patch failed.
+1	asflicense	46	The patch does not generate ASF License warnings.
		6423

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-875/2/artifact/out/Dockerfile
GITHUB PR	#875
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname	Linux 5b1c3b32eed0 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `f1552f6`
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-875/2/artifact/out/diff-checkstyle-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-875/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-875/2/testReport/
Max. process+thread count	4569 (vs. ulimit of 5500)
modules	C: hadoop-ozone/common hadoop-ozone/ozone-manager U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-875/2/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-05-30T21:46:30Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	56	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	18	Maven dependency ordering for branch
+1	mvninstall	573	trunk passed
+1	compile	258	trunk passed
+1	checkstyle	71	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	814	branch has no errors when building and testing our client artifacts.
+1	javadoc	155	trunk passed
0	spotbugs	297	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	492	trunk passed
		_ Patch Compile Tests _
0	mvndep	16	Maven dependency ordering for patch
+1	mvninstall	481	the patch passed
+1	compile	291	the patch passed
+1	cc	291	the patch passed
+1	javac	291	the patch passed
-0	checkstyle	33	hadoop-ozone: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	660	patch has no errors when building and testing our client artifacts.
+1	javadoc	154	the patch passed
+1	findbugs	497	the patch passed
		_ Other Tests _
+1	unit	230	hadoop-hdds in the patch passed.
-1	unit	1741	hadoop-ozone in the patch failed.
+1	asflicense	66	The patch does not generate ASF License warnings.
		6823

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-875/3/artifact/out/Dockerfile
GITHUB PR	#875
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname	Linux d8f1c068b93d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `f1552f6`
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-875/3/artifact/out/diff-checkstyle-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-875/3/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-875/3/testReport/
Max. process+thread count	4364 (vs. ulimit of 5500)
modules	C: hadoop-ozone/common hadoop-ozone/ozone-manager U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-875/3/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-05-30T22:43:27Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	84	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	60	Maven dependency ordering for branch
+1	mvninstall	675	trunk passed
+1	compile	284	trunk passed
+1	checkstyle	77	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	892	branch has no errors when building and testing our client artifacts.
+1	javadoc	147	trunk passed
0	spotbugs	296	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	489	trunk passed
		_ Patch Compile Tests _
0	mvndep	18	Maven dependency ordering for patch
+1	mvninstall	509	the patch passed
+1	compile	273	the patch passed
+1	cc	273	the patch passed
+1	javac	273	the patch passed
+1	checkstyle	44	The patch passed checkstyle in hadoop-hdds
+1	checkstyle	46	hadoop-ozone: The patch generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	670	patch has no errors when building and testing our client artifacts.
+1	javadoc	159	the patch passed
+1	findbugs	513	the patch passed
		_ Other Tests _
-1	unit	314	hadoop-hdds in the patch failed.
-1	unit	1552	hadoop-ozone in the patch failed.
+1	asflicense	60	The patch does not generate ASF License warnings.
		7079

Reason	Tests
Failed junit tests	hadoop.hdds.scm.block.TestBlockManager
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestBCSID
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-875/4/artifact/out/Dockerfile
GITHUB PR	#875
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname	Linux c171e1df5d5b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `33c62f8`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-875/4/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-875/4/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-875/4/testReport/
Max. process+thread count	4952 (vs. ulimit of 5500)
modules	C: hadoop-ozone/common hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-875/4/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

This addresses some minor grammatical issues. Author: Jeffrey Dallatezza <[email protected]> Reviewers: Prateek Maheshwari <[email protected]> Closes apache#875 from jsdt/master

HDDS-1608. Support Ozone Prefix ACLs in OM metadata table. Contribute…

3bf4827

…d by Xiaoyu Yao.

xiaoyuyao requested a review from ajayydv May 30, 2019 18:14

xiaoyuyao self-assigned this May 30, 2019

xiaoyuyao added the ozone label May 30, 2019

bharatviswa504 reviewed May 30, 2019

View reviewed changes

hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/codec/TestOmPrefixInfoCodec.java Show resolved Hide resolved

Adding license header for TestOmPrefixInfoCodec.java

79ff3c8

bharatviswa504 approved these changes May 30, 2019

View reviewed changes

xiaoyuyao added 2 commits May 30, 2019 12:08

Add the prefix table to om metadata store

e88ec00

fix checkstyle

89005e5

xiaoyuyao merged commit 219e286 into apache:trunk May 30, 2019

xiaoyuyao deleted the HDDS-1608 branch May 30, 2019 23:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDDS-1608. Support Ozone Prefix ACLs in OM metadata table. Contribute… #875

HDDS-1608. Support Ozone Prefix ACLs in OM metadata table. Contribute… #875

Uh oh!

xiaoyuyao commented May 30, 2019

Uh oh!

bharatviswa504 left a comment

Uh oh!

Uh oh!

bharatviswa504 left a comment

Uh oh!

hadoop-yetus commented May 30, 2019

Uh oh!

hadoop-yetus commented May 30, 2019

Uh oh!

hadoop-yetus commented May 30, 2019

Uh oh!

hadoop-yetus commented May 30, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HDDS-1608. Support Ozone Prefix ACLs in OM metadata table. Contribute… #875

HDDS-1608. Support Ozone Prefix ACLs in OM metadata table. Contribute… #875

Uh oh!

Conversation

xiaoyuyao commented May 30, 2019

Uh oh!

bharatviswa504 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bharatviswa504 left a comment

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented May 30, 2019

Uh oh!

hadoop-yetus commented May 30, 2019

Uh oh!

hadoop-yetus commented May 30, 2019

Uh oh!

hadoop-yetus commented May 30, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants