HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar. #828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
xiaoyuyao
reviewed
May 17, 2019
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConsts.java
Show resolved
Hide resolved
xiaoyuyao
reviewed
May 17, 2019
xiaoyuyao
reviewed
May 17, 2019
anuengineer
reviewed
May 18, 2019
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConsts.java
Show resolved
Hide resolved
| <property> | ||
| <name>ozone.om.group.rights</name> | ||
| <value>READ_WRITE</value> | ||
| <value>ALL</value> |
Contributor
There was a problem hiding this comment.
Can we please use the new config style ..
Contributor
There was a problem hiding this comment.
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rest/RestClient.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
Show resolved
Hide resolved
| try { | ||
| aclRights.add(OzoneAclRights.valueOf(right.name())); | ||
| } catch (IllegalArgumentException iae) { | ||
| LOG.error("ACL:{} right is not recognized.", acl); |
Contributor
There was a problem hiding this comment.
This should be more than a LOG.Error? if we don't recognize an ACL shouldn't we return an error to the caller instead of ignoring and continue?
Contributor
Author
There was a problem hiding this comment.
Since this involves a list of acls IMO a single bad acl type should not halt the usage of remaining ones. But i am open to change if you think we should throw error at this point.
Contributor
There was a problem hiding this comment.
Agree with @anuengineer based on offline discussion with @ajayydv . We should stop here instead of catch and let the parsing continue.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
xiaoyuyao
reviewed
May 20, 2019
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/protocolPB/OMPBHelper.java
Show resolved
Hide resolved
xiaoyuyao
reviewed
May 20, 2019
| for(OzoneAclRights acl:aclInfo.getRightsList()) { | ||
| try { | ||
| aclRights.add(ACLType.valueOf(acl.name())); | ||
| } catch(IllegalArgumentException iae) { |
Contributor
There was a problem hiding this comment.
remove the try catch. Same as above.
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
Thanks @ajayydv for working on this. +1, please confirm unit test failure are not related. |
Contributor
Author
|
test failures look unrelated. All failed tests passed locally. |
Contributor
Author
|
@xiaoyuyao thanks for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.