You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is dependent on HDDS-1499 and HDDS-1512. This PR has commits from HDDS-1499 and HDDS-1512.
Note for reviewers:
The last commit is part of this Jira. Opened a PR to get a Jenkins run and to get initial comments on the class design and refactor approach, so that similar can be followed for other requests.
The patch appears to include 10 new or modified test files.
_ trunk Compile Tests _
0
mvndep
87
Maven dependency ordering for branch
+1
mvninstall
587
trunk passed
+1
compile
281
trunk passed
+1
checkstyle
84
trunk passed
+1
mvnsite
0
trunk passed
+1
shadedclient
953
branch has no errors when building and testing our client artifacts.
+1
javadoc
152
trunk passed
0
spotbugs
306
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
512
trunk passed
_ Patch Compile Tests _
0
mvndep
30
Maven dependency ordering for patch
+1
mvninstall
472
the patch passed
+1
compile
277
the patch passed
+1
cc
277
the patch passed
+1
javac
277
the patch passed
+1
checkstyle
78
the patch passed
+1
mvnsite
0
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
705
patch has no errors when building and testing our client artifacts.
-1
javadoc
74
hadoop-ozone generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
-1
findbugs
214
hadoop-hdds generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)
_ Other Tests _
-1
unit
173
hadoop-hdds in the patch failed.
-1
unit
1170
hadoop-ozone in the patch failed.
+1
asflicense
46
The patch does not generate ASF License warnings.
6511
Reason
Tests
FindBugs
module:hadoop-hdds
Synchronization performed on java.util.concurrent.ConcurrentHashMap in org.apache.hadoop.utils.db.cache.PartialTableCache.evictCache(long) At PartialTableCache.java:org.apache.hadoop.utils.db.cache.PartialTableCache.evictCache(long) At PartialTableCache.java:[line 90]
Synchronization performed on java.util.concurrent.ConcurrentHashMap in org.apache.hadoop.utils.db.cache.PartialTableCache.get(CacheKey) At PartialTableCache.java:org.apache.hadoop.utils.db.cache.PartialTableCache.get(CacheKey) At PartialTableCache.java:[line 61]
Synchronization performed on java.util.concurrent.ConcurrentHashMap in org.apache.hadoop.utils.db.cache.PartialTableCache.put(CacheKey, CacheValue) At PartialTableCache.java:org.apache.hadoop.utils.db.cache.PartialTableCache.put(CacheKey, CacheValue) At PartialTableCache.java:[line 68]
The patch appears to include 10 new or modified test files.
_ trunk Compile Tests _
0
mvndep
65
Maven dependency ordering for branch
+1
mvninstall
519
trunk passed
+1
compile
279
trunk passed
+1
checkstyle
75
trunk passed
+1
mvnsite
0
trunk passed
+1
shadedclient
826
branch has no errors when building and testing our client artifacts.
+1
javadoc
146
trunk passed
0
spotbugs
283
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
472
trunk passed
_ Patch Compile Tests _
0
mvndep
28
Maven dependency ordering for patch
+1
mvninstall
459
the patch passed
+1
compile
254
the patch passed
+1
cc
254
the patch passed
+1
javac
254
the patch passed
+1
checkstyle
71
the patch passed
+1
mvnsite
0
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
610
patch has no errors when building and testing our client artifacts.
-1
javadoc
83
hadoop-ozone generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
-1
findbugs
212
hadoop-hdds generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)
_ Other Tests _
-1
unit
150
hadoop-hdds in the patch failed.
-1
unit
1100
hadoop-ozone in the patch failed.
+1
asflicense
43
The patch does not generate ASF License warnings.
9095
Reason
Tests
FindBugs
module:hadoop-hdds
Synchronization performed on java.util.concurrent.ConcurrentHashMap in org.apache.hadoop.utils.db.cache.PartialTableCache.evictCache(long) At PartialTableCache.java:org.apache.hadoop.utils.db.cache.PartialTableCache.evictCache(long) At PartialTableCache.java:[line 90]
Synchronization performed on java.util.concurrent.ConcurrentHashMap in org.apache.hadoop.utils.db.cache.PartialTableCache.get(CacheKey) At PartialTableCache.java:org.apache.hadoop.utils.db.cache.PartialTableCache.get(CacheKey) At PartialTableCache.java:[line 61]
Synchronization performed on java.util.concurrent.ConcurrentHashMap in org.apache.hadoop.utils.db.cache.PartialTableCache.put(CacheKey, CacheValue) At PartialTableCache.java:org.apache.hadoop.utils.db.cache.PartialTableCache.put(CacheKey, CacheValue) At PartialTableCache.java:[line 68]
To be consistent with put(), null values in input should be delete operation
Author: Wei Song <[email protected]>
Reviewers: Ahmed Abdul Hamid <[email protected]>
Closesapache#827 from weisong44/SAMZA-2010
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.